New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make blob new and edit file editors more uniform #7951

Merged
merged 1 commit into from Jan 15, 2015

Conversation

4 participants
@cirosantilli
Contributor

cirosantilli commented Oct 3, 2014

DRY them up and make them uniform. UI changes:

  • remove cancel button from file edit header: there is already a Cancel button the bottom of the page, which is the standard place for cancel buttons
  • add branch to new file edit. Already present on the edit, so let's make it uniform.

After edit: no cancel:

screenshot from 2014-10-03 14 17 30 factor editor after

Before edit:

screenshot from 2014-10-03 14 25 18 blob edit before

After new (has branch on header):

screenshot from 2014-10-03 14 24 44 blob new after

Before new:

screenshot from 2014-10-03 14 25 29 blob new before

@TeatroIO

This comment has been minimized.

TeatroIO commented Oct 3, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title from Make blob new and edit file editors more uniform to [WIP] Make blob new and edit file editors more uniform Oct 3, 2014

@cirosantilli cirosantilli force-pushed the cirosantilli:uniform-blob-edit branch from 501938d to 16ecd12 Oct 3, 2014

@cirosantilli cirosantilli changed the title from [WIP] Make blob new and edit file editors more uniform to Make blob new and edit file editors more uniform Oct 3, 2014

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Dec 14, 2014

@cirosantilli Can you please make this mergeable?

@cirosantilli cirosantilli force-pushed the cirosantilli:uniform-blob-edit branch from 16ecd12 to 3a3b0da Dec 30, 2014

@cirosantilli cirosantilli changed the title from Make blob new and edit file editors more uniform to [WIP] Make blob new and edit file editors more uniform Dec 30, 2014

@cirosantilli cirosantilli changed the title from [WIP] Make blob new and edit file editors more uniform to Make blob new and edit file editors more uniform Dec 30, 2014

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Dec 30, 2014

@jvanbaarsen updated.

@jvanbaarsen jvanbaarsen added this to the 7.7 milestone Jan 4, 2015

@dzaporozhets dzaporozhets modified the milestones: 7.7, 7.8 Jan 13, 2015

dzaporozhets added a commit that referenced this pull request Jan 15, 2015

Merge pull request #7951 from cirosantilli/uniform-blob-edit
Make blob new and edit file editors more uniform

@dzaporozhets dzaporozhets merged commit 6f78be4 into gitlabhq:master Jan 15, 2015

2 checks passed

default Hound has reviewed the changes.
semaphoreci The build passed on Semaphore.
Details
@dzaporozhets

This comment has been minimized.

Member

dzaporozhets commented Jan 15, 2015

Thanks

@cirosantilli cirosantilli deleted the cirosantilli:uniform-blob-edit branch Jan 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment