New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor admin logs [failure unrelated] #7961

Merged
merged 1 commit into from Oct 21, 2014

Conversation

4 participants
@cirosantilli
Contributor

cirosantilli commented Oct 4, 2014

Same HTML, less lines, less magic constants.

Are there points in the code the reviewer needs to double check?

That adding the new production and sidekiq loggers does not create problems for production apps.

@TeatroIO

This comment has been minimized.

TeatroIO commented Oct 4, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title from Dry admin logs. to Factor admin logs Oct 4, 2014

@cirosantilli cirosantilli changed the title from Factor admin logs to [WIP] Factor admin logs Oct 5, 2014

@cirosantilli cirosantilli force-pushed the cirosantilli:dry-log-file-names branch from 8c7926f to 9bebacd Oct 5, 2014

@cirosantilli cirosantilli changed the title from [WIP] Factor admin logs to Factor admin logs [WIP] Oct 6, 2014

@cirosantilli cirosantilli changed the title from Factor admin logs [WIP] to Factor admin logs [failure unrelated] Oct 6, 2014

@Razer6 Razer6 added this to the 7.4 milestone Oct 13, 2014

@dzaporozhets dzaporozhets modified the milestones: 7.5, 7.4 Oct 15, 2014

dzaporozhets added a commit that referenced this pull request Oct 21, 2014

Merge pull request #7961 from cirosantilli/dry-log-file-names
Factor admin logs [failure unrelated]

@dzaporozhets dzaporozhets merged commit ee068e7 into gitlabhq:master Oct 21, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:dry-log-file-names branch Oct 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment