New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor markup? || gitlab_markdown? into new method #7963

Merged
merged 1 commit into from Oct 7, 2014

Conversation

4 participants
@cirosantilli
Contributor

cirosantilli commented Oct 4, 2014

This pattern deserves a method for it: it is very intuitive.

@TeatroIO

This comment has been minimized.

TeatroIO commented Oct 4, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title from Factor markup? || gitlab_markdown? into new method to [WIP] Factor markup? || gitlab_markdown? into new method Oct 4, 2014

@cirosantilli cirosantilli changed the title from [WIP] Factor markup? || gitlab_markdown? into new method to Factor markup? || gitlab_markdown? into new method [failure unrelated] Oct 5, 2014

@Razer6 Razer6 added this to the 7.4 milestone Oct 7, 2014

@cirosantilli cirosantilli changed the title from Factor markup? || gitlab_markdown? into new method [failure unrelated] to Factor markup? || gitlab_markdown? into new method Oct 7, 2014

dzaporozhets added a commit that referenced this pull request Oct 7, 2014

Merge pull request #7963 from cirosantilli/factor-previewable
Factor markup? || gitlab_markdown? into new method

@dzaporozhets dzaporozhets merged commit 7bcd6f7 into gitlabhq:master Oct 7, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:factor-previewable branch Oct 7, 2014

tigefa4u pushed a commit to tigefa4u/gitlabhq that referenced this pull request Nov 6, 2018

Merge branch '7963-geo-rails-console-message-display-primary-secondar…
…y-state-incorrectly' into 'master'

Geo: Rails console message display primary/secondary state incorrectly

Closes gitlabhq#7963

See merge request gitlab-org/gitlab-ee!7952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment