Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for tree edit routes #7978

Merged
merged 1 commit into from Dec 20, 2014

Conversation

5 participants
@cirosantilli
Copy link
Contributor

commented Oct 6, 2014

Critical because of possible confusion between /:id/preview
and /:id for a path that ends in preview.

The goal it to prevent a bug analogous to: #7977

@TeatroIO

This comment has been minimized.

Copy link

commented Oct 6, 2014

I've prepared a stage. Click to open.

it 'to #show' do
get('/gitlab/gitlabhq/edit/master/app/models/project.rb').should(
route_to('projects/edit_tree#show', project_id: 'gitlab/gitlabhq',
id: 'master/app/models/project.rb'))

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Oct 6, 2014

Align the elements of a hash literal if they span more than one line.

id: 'master/app/models/project.rb'))
get('/gitlab/gitlabhq/edit/master/app/models/project.rb/preview').should(
route_to('projects/edit_tree#show', project_id: 'gitlab/gitlabhq',
id: 'master/app/models/project.rb/preview'))

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Oct 6, 2014

Align the elements of a hash literal if they span more than one line.

id: 'master/app/models/project.rb/preview'))
post('/gitlab/gitlabhq/edit/master/app/models/project.rb/preview').should(
route_to('projects/edit_tree#preview', project_id: 'gitlab/gitlabhq',
id: 'master/app/models/project.rb'))

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Oct 6, 2014

Align the elements of a hash literal if they span more than one line.

Add tests for tree edit routes
Critical because of possible confusion between /:id/preview
and /:id for a path that ends in preview.

@cirosantilli cirosantilli force-pushed the cirosantilli:edit-preview-route-test branch from 44106a5 to f4efb19 Oct 7, 2014

@cirosantilli cirosantilli changed the title Add tests for tree edit routes Add tests for tree edit routes [failure unrelated] Oct 7, 2014

@jvanbaarsen

This comment has been minimized.

Copy link
Contributor

commented Dec 14, 2014

@cirosantilli Thanks!

@jvanbaarsen jvanbaarsen changed the title Add tests for tree edit routes [failure unrelated] Add tests for tree edit routes Dec 14, 2014

dzaporozhets added a commit that referenced this pull request Dec 20, 2014

@dzaporozhets dzaporozhets merged commit 6a5766e into gitlabhq:master Dec 20, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:edit-preview-route-test branch Dec 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.