New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded app/finders config.autoload path #7994

merged 1 commit into from Oct 22, 2014


4 participants

cirosantilli commented Oct 7, 2014

Every directory directly under app/ is already searched by default because it is under eager_load_path as mentioned at:

config.eager_load_paths accepts an array of paths from which Rails will eager load on boot if cache classes is enabled. Defaults to every folder in the app directory of the application.

and empirically verified.

This is for example why services can be used from controllers magically.

Remove unneeded app/finders config.autoload path
Every directory under app/ is searched by default

This comment has been minimized.

TeatroIO commented Oct 7, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title from [WIP] Remove unneeded app/finders config.autoload path to Remove unneeded app/finders config.autoload path Oct 7, 2014

@Razer6 Razer6 added this to the 7.4 milestone Oct 8, 2014

@dzaporozhets dzaporozhets modified the milestones: 7.4, 7.5 Oct 15, 2014

dzaporozhets added a commit that referenced this pull request Oct 22, 2014

Merge pull request #7994 from cirosantilli/rm-unneeded-autoload-path
Remove unneeded app/finders config.autoload path

@dzaporozhets dzaporozhets merged commit 3220e19 into gitlabhq:master Oct 22, 2014

1 check passed

default The build passed on Semaphore.

@cirosantilli cirosantilli deleted the cirosantilli:rm-unneeded-autoload-path branch Oct 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment