New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gitlab.config instead of Settings everywhere #8005

Merged
merged 1 commit into from Oct 27, 2014

Conversation

5 participants
@cirosantilli
Contributor

cirosantilli commented Oct 10, 2014

They are the same because of

, but Gitlab.config is used far more than Settings, so let's use it everywhere.

I wonder why though: Settings is shorter, easier to understand since it is the same for every app that uses settings logic. Took me a while to find that 2_app.rb file.

@TeatroIO

This comment has been minimized.

TeatroIO commented Oct 10, 2014

I've prepared a stage. Click to open.

@amtrack

This comment has been minimized.

amtrack commented Oct 11, 2014

👍 for consistency
and 👍 for maybe refactoring it to Settings in the future. Took me a while to find 2_app.rb as well

@cirosantilli cirosantilli force-pushed the cirosantilli:settings-to-gitlab-config branch from ef432df to 8323cab Oct 13, 2014

@cirosantilli cirosantilli changed the title from Use Gitlab.config instead of Settings everywhere to [WIP] Use Gitlab.config instead of Settings everywhere Oct 13, 2014

@cirosantilli cirosantilli force-pushed the cirosantilli:settings-to-gitlab-config branch from 8323cab to 39c66c8 Oct 15, 2014

@cirosantilli cirosantilli changed the title from [WIP] Use Gitlab.config instead of Settings everywhere to Use Gitlab.config instead of Settings everywhere Oct 15, 2014

@Razer6 Razer6 added this to the 7.5 milestone Oct 23, 2014

dzaporozhets added a commit that referenced this pull request Oct 27, 2014

Merge pull request #8005 from cirosantilli/settings-to-gitlab-config
Use Gitlab.config instead of Settings everywhere

@dzaporozhets dzaporozhets merged commit f4178f9 into gitlabhq:master Oct 27, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:settings-to-gitlab-config branch Oct 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment