New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor authorize_push! and authorize_code_access! #8030

merged 1 commit into from Oct 21, 2014


4 participants

cirosantilli commented Oct 13, 2014

with existing method_missing in the same controller.

The pattern of leaving standard named methods like authorize_ to method_missing is already used extensively, so let's be consistent and use it everywhere.

git ls-files | xargs perl -lapi -e 's/authorize_code_access!/authorize_download_code!/g'
git ls-files | xargs perl -lapi -e 's/authorize_push!/authorize_push_code!/g'
Factor authorize_push! and authorize_code_access!
with existing method_missing. Pattern already used extensively,
so let's be consistent and use it everywhere.

This comment has been minimized.

TeatroIO commented Oct 13, 2014

I've prepared a stage. Click to open.


This comment has been minimized.


dblessing commented Oct 20, 2014

dzaporozhets added a commit that referenced this pull request Oct 21, 2014

Merge pull request #8030 from cirosantilli/factor-authorize
Factor authorize_push! and authorize_code_access!

@dzaporozhets dzaporozhets merged commit 8ad9a75 into gitlabhq:master Oct 21, 2014

1 check passed

default The build passed on Semaphore.

@cirosantilli cirosantilli deleted the cirosantilli:factor-authorize branch Oct 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment