Skip to content

Conversation

@cirosantilli
Copy link
Contributor

in app controller, user model and services.

Same code repeated 3 times.

Same behavior, less lines, and slightly more time efficient since:

  • a single @abilities is constructed once for the entire app
  • no more add_abilities filter before every action of the app, yay!

@TeatroIO
Copy link

I've prepared a stage. Click to open.

in app controller, user model and services.
@cirosantilli cirosantilli force-pushed the factor-ability-abilities branch from 6b1ddda to b66a152 Compare October 19, 2014 09:12
@cirosantilli cirosantilli changed the title [WIP] Factor abilities methods Factor abilities methods Oct 19, 2014
@Razer6 Razer6 added this to the 7.5 milestone Oct 23, 2014
dzaporozhets added a commit that referenced this pull request Oct 28, 2014
@dzaporozhets dzaporozhets merged commit beabf5d into gitlabhq:master Oct 28, 2014
@cirosantilli cirosantilli deleted the factor-ability-abilities branch October 28, 2014 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants