New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor permission check in issuable finder #8092

Merged
merged 1 commit into from Mar 2, 2015

Conversation

6 participants
@cirosantilli
Contributor

cirosantilli commented Oct 19, 2014

This reimplements abilities logic.

DRYed it up.

Tests will fail before the following dependency is met:

@TeatroIO

This comment has been minimized.

TeatroIO commented Oct 19, 2014

I've prepared a stage. Click to open.

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Dec 13, 2014

@cirosantilli The mentioned MR has been merged, can you please rebase to make the tests green?

@cirosantilli cirosantilli force-pushed the cirosantilli:factor-finder-perms branch from 113a7dc to 260d327 Dec 30, 2014

@cirosantilli cirosantilli changed the title from Factor permission check in issuable finder to [WIP] Factor permission check in issuable finder Dec 30, 2014

@cirosantilli cirosantilli changed the title from [WIP] Factor permission check in issuable finder to Factor permission check in issuable finder [failure unrelated] Jan 1, 2015

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Jan 1, 2015

@jvanbaarsen updated.

@cirosantilli cirosantilli force-pushed the cirosantilli:factor-finder-perms branch from 260d327 to d37cf2a Jan 1, 2015

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Jan 4, 2015

Retriggered the build

@dblessing dblessing changed the title from Factor permission check in issuable finder [failure unrelated] to Factor permission check in issuable finder Jan 17, 2015

@jvanbaarsen jvanbaarsen added this to the 7.8 milestone Feb 7, 2015

@Razer6 Razer6 modified the milestones: 7.9, 7.8 Feb 23, 2015

dzaporozhets added a commit that referenced this pull request Mar 2, 2015

Merge pull request #8092 from cirosantilli/factor-finder-perms
Factor permission check in issuable finder

@dzaporozhets dzaporozhets merged commit 7faae7c into gitlabhq:master Mar 2, 2015

2 checks passed

default Hound has reviewed the changes.
semaphoreci The build passed on Semaphore.
Details
@dzaporozhets

This comment has been minimized.

Member

dzaporozhets commented Mar 2, 2015

Thank you

@cirosantilli cirosantilli deleted the cirosantilli:factor-finder-perms branch Mar 3, 2015

rymai pushed a commit that referenced this pull request Feb 24, 2016

rymai pushed a commit that referenced this pull request Feb 24, 2016

Merge branch 'activity-tabs-single-select' into 'master'
Treats activity tabs as single select

Fixes #8092

![activity-tabs](/uploads/1fb4d9233492252cfd93c74579e97514/activity-tabs.gif)

See merge request !2940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment