New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY mentioned in magic note constant #8097

Merged
merged 1 commit into from Oct 21, 2014

Conversation

4 participants
@cirosantilli
Contributor

cirosantilli commented Oct 19, 2014

Magic string _mentioned in appeared 3 times.

@kemenaran, @mr-vinn, @randx: you may have written those lines: let's avoid repeating magic constants more than once, specially when they show on the UI. They break later with high probability.

@TeatroIO

This comment has been minimized.

TeatroIO commented Oct 19, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli force-pushed the cirosantilli:dry-mentioned-in branch from 467120d to ebd1222 Oct 19, 2014

@cirosantilli cirosantilli force-pushed the cirosantilli:dry-mentioned-in branch from ebd1222 to f808ecf Oct 19, 2014

@cirosantilli cirosantilli changed the title from [WIP] DRY mentioned in magic note constant to DRY mentioned in magic note constant Oct 19, 2014

@dzaporozhets

This comment has been minimized.

Member

dzaporozhets commented Oct 20, 2014

👍

dzaporozhets added a commit that referenced this pull request Oct 21, 2014

Merge pull request #8097 from cirosantilli/dry-mentioned-in
DRY mentioned in magic note constant

@dzaporozhets dzaporozhets merged commit d545bb8 into gitlabhq:master Oct 21, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:dry-mentioned-in branch Oct 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment