New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State on CONTRIBUTING that people should fix line style of touched lines #8109

Merged
merged 1 commit into from Oct 21, 2014

Conversation

4 participants
@cirosantilli
Contributor

cirosantilli commented Oct 20, 2014

No description provided.

@TeatroIO

This comment has been minimized.

TeatroIO commented Oct 20, 2014

I've prepared a stage. Click to open.

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Oct 20, 2014

Sorry, forgot the skip ci.

@cirosantilli cirosantilli force-pushed the cirosantilli:contributing-style-vs-min branch from 665e1d6 to e27a0dc Oct 20, 2014

1. It conforms to the following style guides
1. It conforms to the following style guides.
If your change touches a line that does not follow the style,
modify the entire line to follow it. This prevents Hound CI from generating warnings.

This comment has been minimized.

@dosire

dosire Oct 21, 2014

Member

Replace 'Hound CI' with 'automatic style checkers', since we might use something else on GitLab.com

This comment has been minimized.

@cirosantilli

cirosantilli Oct 21, 2014

Contributor

OK. What are you using? IMHO the ideal solution would be to have a checker that runs locally and make it run on the CI.

This comment has been minimized.

@dosire

dosire Oct 21, 2014

Member

Sure, we used something else but I'm not sure it is activated now. Anyway, thanks for the change.

@cirosantilli cirosantilli force-pushed the cirosantilli:contributing-style-vs-min branch from e27a0dc to b9314ee Oct 21, 2014

1. It conforms to the following style guides
1. It conforms to the following style guides.
If your change touches a line that does not follow the style,
modify the entire line to follow it. This prevents automatic style checkers from generating warnings.

This comment has been minimized.

@dosire

dosire Oct 21, 2014

Member

Consider the following change since we refer to linting tools later in the text.

This prevents automatic style checkers from generating warnings.
=>
This prevents automatic style checkers ('linting tools') from generating warnings.

This comment has been minimized.

@cirosantilli

cirosantilli Oct 21, 2014

Contributor

How about just:

This prevents linting tools from generating warnings.

It's the precise term already.

This comment has been minimized.

@dosire

dosire Oct 21, 2014

Member

Even better.

@dosire

This comment has been minimized.

Member

dosire commented Oct 21, 2014

👍 for me

@cirosantilli cirosantilli force-pushed the cirosantilli:contributing-style-vs-min branch from b9314ee to 19ab9b4 Oct 21, 2014

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Oct 21, 2014

Updated.

dosire added a commit that referenced this pull request Oct 21, 2014

Merge pull request #8109 from cirosantilli/contributing-style-vs-min
State on CONTRIBUTING that people should fix line style of touched lines

@dosire dosire merged commit 6d7c4c0 into gitlabhq:master Oct 21, 2014

1 check was pending

default The build is pending on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:contributing-style-vs-min branch Oct 21, 2014

stanhu pushed a commit that referenced this pull request Jan 15, 2016

Jacob Schatz Jacob Schatz
Fix javascript error with deleting messages in issue or merge request
Elements searched for by jQuery no longer existed in the DOM.
Javascript was also unnecessarily complex, for using jQuery
Fixes #8109

stanhu pushed a commit that referenced this pull request Jan 15, 2016

Merge branch 'deleting-a-note-after-editing-another-results-in-a-java…
…script-error' into 'master'


Fix javascript error with deleting messages in issue or merge request

Elements searched for by jQuery no longer existed in the DOM.
Javascript was also unnecessarily complex, for using jQuery

Fixes #8109

See merge request !2442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment