New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export all coffee classes with @ #8110

Merged
merged 1 commit into from Oct 21, 2014

Conversation

4 participants
@cirosantilli
Contributor

cirosantilli commented Oct 20, 2014

DRY, uniform.

find . -iname "*.coffee" | xargs perl -0777 -pi -e 's/^(class )([^@].*[^\n]\n)\n+(@|this)[^\n]+\n*(?=\n|$)/\1@\2/s'
find . -iname "*.coffee" | xargs perl -lapi -e 's/^class window\./class @/'

And thanks to @Razer6 for teaching me that today.

@TeatroIO

This comment has been minimized.

TeatroIO commented Oct 20, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title from Export all coffee classes with @ to [WIP] Export all coffee classes with @ Oct 20, 2014

@cirosantilli cirosantilli changed the title from [WIP] Export all coffee classes with @ to Export all coffee classes with @ Oct 20, 2014

@Razer6

This comment has been minimized.

Member

Razer6 commented Oct 21, 2014

Given first coffee script advice ❤️

Razer6 added a commit that referenced this pull request Oct 21, 2014

@Razer6 Razer6 merged commit ad774c2 into gitlabhq:master Oct 21, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:coffee-uniform-export branch Oct 21, 2014

dzaporozhets pushed a commit that referenced this pull request Jul 20, 2016

Merge branch 'issue_8110' into 'master'
Allow slack service to send messages on different channels

closes #8110 

## Allow slack service to send messages on different channels  

![new_slack_service](/uploads/87de0bd6b02a4f7853358676b5e74dff/new_slack_service.png)

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !5124

rymai added a commit that referenced this pull request Jul 21, 2016

Merge branch 'issue_8110' into 'master'
Allow slack service to send messages on different channels

closes #8110 

## Allow slack service to send messages on different channels  

![new_slack_service](/uploads/87de0bd6b02a4f7853358676b5e74dff/new_slack_service.png)

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !5124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment