New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run avatar chooser Js on pages that need it [failure unrelated] #8114

Merged
merged 1 commit into from Oct 23, 2014

Conversation

5 participants
@cirosantilli
Contributor

cirosantilli commented Oct 20, 2014

Before this PR, that code was run on all pages, making our app slower =(

Now it uses the dispatch system to run only when needed! Yay.

$ -> is evil.

@TeatroIO

This comment has been minimized.

TeatroIO commented Oct 20, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title from Only run avatar chooser Js on pages that need it to [WIp] Only run avatar chooser Js on pages that need it Oct 20, 2014

@cirosantilli cirosantilli force-pushed the cirosantilli:rm-global-avatar-js branch from 206d59b to 2c2b6ea Oct 20, 2014

@cirosantilli cirosantilli changed the title from [WIp] Only run avatar chooser Js on pages that need it to [WIP] Only run avatar chooser Js on pages that need it Oct 20, 2014

@dzaporozhets

This comment has been minimized.

Member

dzaporozhets commented Oct 21, 2014

nice

@cirosantilli cirosantilli force-pushed the cirosantilli:rm-global-avatar-js branch from 2c2b6ea to 38670a6 Oct 21, 2014

@cirosantilli cirosantilli changed the title from [WIP] Only run avatar chooser Js on pages that need it to Only run avatar chooser Js on pages that need it [failure unrelated] Oct 21, 2014

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Oct 21, 2014

Updated.

@axilleas

This comment has been minimized.

Member

axilleas commented Oct 22, 2014

I triggered a rebuild, let's see.

Razer6 added a commit that referenced this pull request Oct 23, 2014

Merge pull request #8114 from cirosantilli/rm-global-avatar-js
Only run avatar chooser Js on pages that need it

@Razer6 Razer6 merged commit e80ef19 into gitlabhq:master Oct 23, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:rm-global-avatar-js branch Oct 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment