Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove whitespace link between user group avatars #8118

Merged
merged 1 commit into from Oct 23, 2014

Conversation

3 participants
@cirosantilli
Copy link
Contributor

commented Oct 21, 2014

After: inter group avatar space slightly reduced by one rogue whitespace:

screenshot from 2014-10-21 20 17 30 after

Before: on hover, rogue whitespace gets underlined like a link to the right of second avatar:

screenshot from 2014-10-21 20 17 08

@TeatroIO

This comment has been minimized.

Copy link

commented Oct 21, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title Remove whitespace link between user group avatars [WIP] Remove whitespace link between user group avatars Oct 21, 2014

@cirosantilli cirosantilli changed the title [WIP] Remove whitespace link between user group avatars Remove whitespace link between user group avatars Oct 21, 2014

@Razer6

This comment has been minimized.

Copy link
Member

commented Oct 23, 2014

Looks good. I saw this yesterday and wanted to look for it 😄

Razer6 added a commit that referenced this pull request Oct 23, 2014

Merge pull request #8118 from cirosantilli/user-groups-space-link
Remove whitespace link between user group avatars

@Razer6 Razer6 merged commit e6e5e63 into gitlabhq:master Oct 23, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:user-groups-space-link branch Oct 23, 2014

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Oct 23, 2014

I was faster! 🔫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.