Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better js -> URL projects map to reduce unneeded execution #8123

Merged
merged 1 commit into from Oct 27, 2014

Conversation

4 participants
@cirosantilli
Copy link
Contributor

commented Oct 21, 2014

This PR splits up the $ -> which run on every page. Now project functions are run on much less pages, making things faster and less error prone.

Projects have been split into 3 Js classes:

  • Project: runs on all project namespace
  • ProjectShow
  • ProjectNew: new and edit
@TeatroIO

This comment has been minimized.

Copy link

commented Oct 21, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title [WIP] Better js -> URL map to reduce unneeded execution Better js -> URL map to reduce unneeded execution Oct 21, 2014

@cirosantilli cirosantilli changed the title Better js -> URL map to reduce unneeded execution Better js -> URL projects map to reduce unneeded execution Oct 21, 2014

@Razer6 Razer6 added this to the 7.5 milestone Oct 23, 2014

dzaporozhets added a commit that referenced this pull request Oct 27, 2014

Merge pull request #8123 from cirosantilli/project-js-only-needed
Better js -> URL projects map to reduce unneeded execution

@dzaporozhets dzaporozhets merged commit 243a74e into gitlabhq:master Oct 27, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:project-js-only-needed branch Oct 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.