Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions doc/update/7.4-to-7.5.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# From 7.4 to 7.5

### Update config files

#### New configuration options for `gitlab.yml`

There are new configuration options available for [`gitlab.yml`](config/gitlab.yml.example). View them with the command below and apply them to your current `gitlab.yml`.

```
git diff origin/7-4-stable:config/gitlab.yml.example origin/7-5-stable:config/gitlab.yml.example
```

#### Setup time zone

Set your time zone in `gitlab.yml` and, if you set it previously, unset it in [`application.rb`](config/application.rb)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bbodenmiller maybe we could make it clear that if you never changed timezone settings then you don't have to do anything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Were you just thinking it should be a separate sentence or paragraph or did you have another idea?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be something like

If you were using a custom time zone in config/..., you can now set the time zone in gitlab.yml like this:...

So that if I am a user who never knew about custom timezones, I can read this paragraph, see I need to take no action, and immediately forget about it again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually wrote it that way because if you previously never set a timezone (since it wasn't supported) you now should.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that setting the timezone will be nice for some GitLab installations. However, considering that the default (UTC if I understand correctly) is sane, I think this settings change should be presented as an optional step, not a necessity. Manual GitLab updates are daunting enough as it is so I believe we should think twice before telling users that they have to take an extra step.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update the text to suggest that they consider setting a time zone. Additionally this is only listed in the upgrade guide and not the installation guide.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

Best regards,

Jacob Vosmaer
GitLab B.V.

2014-11-18 23:06 GMT+01:00 Ben Bodenmiller notifications@github.com:

In doc/update/7.4-to-7.5.md:

@@ -0,0 +1,15 @@
+# From 7.4 to 7.5
+
+### Update config files
+
+#### New configuration options for gitlab.yml
+
+There are new configuration options available for gitlab.yml. View them with the command below and apply them to your current gitlab.yml.
+
+ +git diff origin/7-4-stable:config/gitlab.yml.example origin/7-5-stable:config/gitlab.yml.example +
+
+#### Setup time zone
+
+Set your time zone in gitlab.yml and, if you set it previously, unset it in application.rb

I'll update the text to suggest that they consider setting a time zone.
Additionally this is only listed in the upgrade guide and not the
installation guide.


Reply to this email directly or view it on GitHub
https://github.com/gitlabhq/gitlabhq/pull/8124/files#r20542322.