-
Notifications
You must be signed in to change notification settings - Fork 5.8k
config time zone #8124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
config time zone #8124
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # From 7.4 to 7.5 | ||
|
|
||
| ### Update config files | ||
|
|
||
| #### New configuration options for `gitlab.yml` | ||
|
|
||
| There are new configuration options available for [`gitlab.yml`](config/gitlab.yml.example). View them with the command below and apply them to your current `gitlab.yml`. | ||
|
|
||
| ``` | ||
| git diff origin/7-4-stable:config/gitlab.yml.example origin/7-5-stable:config/gitlab.yml.example | ||
| ``` | ||
|
|
||
| #### Setup time zone | ||
|
|
||
| Set your time zone in `gitlab.yml` and, if you set it previously, unset it in [`application.rb`](config/application.rb) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bbodenmiller maybe we could make it clear that if you never changed timezone settings then you don't have to do anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Were you just thinking it should be a separate sentence or paragraph or did you have another idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be something like
So that if I am a user who never knew about custom timezones, I can read this paragraph, see I need to take no action, and immediately forget about it again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually wrote it that way because if you previously never set a timezone (since it wasn't supported) you now should.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that setting the timezone will be nice for some GitLab installations. However, considering that the default (UTC if I understand correctly) is sane, I think this settings change should be presented as an optional step, not a necessity. Manual GitLab updates are daunting enough as it is so I believe we should think twice before telling users that they have to take an extra step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update the text to suggest that they consider setting a time zone. Additionally this is only listed in the upgrade guide and not the installation guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK!
Best regards,
Jacob Vosmaer
GitLab B.V.
2014-11-18 23:06 GMT+01:00 Ben Bodenmiller notifications@github.com: