Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run user select Js only where needed #8127

Merged

Conversation

5 participants
@cirosantilli
Copy link
Contributor

commented Oct 21, 2014

Transform current implementation into regular Coffescript classes
so that the same call method can be reused on the dispatcher
as for other classes.

Same rationale as: #8123

I have built the map by grepping for the touched classes + testing it out.

Double check

That I didn't make any mistakes when converting the existing coffee into classes.

The only changes are:

  • formatResult and formatSelection became instance methods. For this to work, callbacks that use them need to bind with => instead of -> ( to avoid repeating class names by using the binded this)
  • removed the prefix from instance methods, e.g. userFormatSelection became just formatSelection since it is already inside the UserSelect class
@TeatroIO

This comment has been minimized.

Copy link

commented Oct 21, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli force-pushed the cirosantilli:user-select-js-only-needed branch from 3be8b04 to c507e90 Oct 22, 2014

@cirosantilli cirosantilli changed the title [WIP] Run user select Js only where needed Run user select Js only where needed Oct 22, 2014

@Razer6 Razer6 added this to the 7.5 milestone Oct 23, 2014

@dblessing

This comment has been minimized.

Copy link
Member

commented Oct 24, 2014

@cirosantilli Can you please make this mergeable?

@cirosantilli cirosantilli force-pushed the cirosantilli:user-select-js-only-needed branch from c507e90 to bea3c04 Oct 24, 2014

@cirosantilli cirosantilli changed the title Run user select Js only where needed [WIP] Run user select Js only where needed Oct 24, 2014

@cirosantilli cirosantilli changed the title [WIP] Run user select Js only where needed Run user select Js only where needed Oct 24, 2014

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Oct 24, 2014

Updated.

@dzaporozhets

This comment has been minimized.

Copy link
Member

commented Oct 27, 2014

@cirosantilli please make mergeable

Run user select Js only where needed
Transform current implementation into regular Coffescript classes
so that the same call method can be reused on the dispatcher
as for other classes.

@cirosantilli cirosantilli force-pushed the cirosantilli:user-select-js-only-needed branch from bea3c04 to 2d18797 Oct 27, 2014

@cirosantilli cirosantilli changed the title Run user select Js only where needed [WIP] Run user select Js only where needed Oct 27, 2014

@cirosantilli cirosantilli changed the title [WIP] Run user select Js only where needed Run user select Js only where needed Oct 27, 2014

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Oct 27, 2014

Updated.

dzaporozhets added a commit that referenced this pull request Oct 28, 2014

Merge pull request #8127 from cirosantilli/user-select-js-only-needed
Run user select Js only where needed

@dzaporozhets dzaporozhets merged commit 26175e4 into gitlabhq:master Oct 28, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:user-select-js-only-needed branch Oct 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.