New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge File basename and dirname into split #8158

Merged
merged 1 commit into from Oct 25, 2014

Conversation

4 participants
@cirosantilli
Contributor

cirosantilli commented Oct 23, 2014

Faster because only does one split in that case.

Merge File basename and direname into split
Faster because only does one split in that case.
@TeatroIO

This comment has been minimized.

TeatroIO commented Oct 23, 2014

I've prepared a stage. Click to open.

@dblessing

This comment has been minimized.

Member

dblessing commented Oct 23, 2014

Not that I'm complaining, but are you just perusing the code looking for little optimizations?

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Oct 24, 2014

My goal is to do https://github.com/booktree/booktree and the features listed there.

My end goal is to implement major features.

In doing so, I dive into the code to see where to interface.

When I see something that is either:

  • wrong
  • smelly
  • suboptimal with a more efficient equally readable alternative

I git grep and fix it once and for all to prevent future bugs from coming up.

In most of those fixes I also end up learning what is the best way of doing something which I was not sure about so I won't do them on the features, and teaching others not to do them when possible.

Razer6 added a commit that referenced this pull request Oct 25, 2014

Merge pull request #8158 from cirosantilli/basename-dirname-split
Merge File basename and direname into split

@Razer6 Razer6 merged commit 199029b into gitlabhq:master Oct 25, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli changed the title from Merge File basename and direname into split to Merge File basename and dirname into split Oct 25, 2014

@cirosantilli cirosantilli deleted the cirosantilli:basename-dirname-split branch Oct 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment