Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dev fixture projects with fixed visibility #8168

Merged
merged 1 commit into from Nov 7, 2014

Conversation

5 participants
@cirosantilli
Copy link
Contributor

commented Oct 26, 2014

Creates 3 new projects: one public, one private and one internal. For each project create a new user which is it's owner.

Really helpful to test cases things where visibility matters

Factor out Sidekiq::Testing.inline! do into the Seeder with 04_projects.

Create a fixtures_development_helper.rb helper file because I am pretty sure that will be reused afterwards.

@TeatroIO

This comment has been minimized.

Copy link

commented Oct 26, 2014

I've prepared a stage. Click to open.

'https://github.com/h5bp/html5-boilerplate.git',
]

project_urls.each_with_index do |url, i|

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Oct 26, 2014

Unused block argument - i. If it's necessary, use _ or _i as an argument name to indicate that it won't be used.

group.add_owner(User.first)
end

project_path.gsub!(".git", "")

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Oct 26, 2014

Prefer single-quoted strings when you don't need string interpolation or special symbols.

new_path = project.repository.path
FileUtils.rm_rf(new_path)
FileUtils.cp_r(FixturesDevelopmentHelper.template_project.repository.path,
new_path)

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Oct 26, 2014

Align the parameters of a method call if they span more than one line.

@cirosantilli cirosantilli force-pushed the cirosantilli:dev-fixtures-visibility branch from c82ddac to a9fadce Oct 26, 2014

maxlazio added a commit that referenced this pull request Nov 7, 2014

Merge pull request #8168 from cirosantilli/dev-fixtures-visibility
Create dev fixture projects with fixed visibility

@maxlazio maxlazio merged commit 1d337de into gitlabhq:master Nov 7, 2014

1 check passed

default The build passed on Semaphore.
Details
@maxlazio

This comment has been minimized.

Copy link
Member

commented Nov 7, 2014

Thanks

@cirosantilli cirosantilli deleted the cirosantilli:dev-fixtures-visibility branch Nov 7, 2014

@@ -1,9 +1,13 @@
require 'sidekiq/testing'

This comment has been minimized.

Copy link
@dzaporozhets

dzaporozhets Nov 10, 2014

Member

This is a bad idea. lib is auto loaded in any environment.

@dzaporozhets

This comment has been minimized.

Copy link
Member

commented Nov 10, 2014

I reverted this PR since it breaks everything sidekiq-related in application

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Nov 10, 2014

@randx sorry for having caused this problem, I have removed the cause of the problem at: #8285

@dzaporozhets

This comment has been minimized.

Copy link
Member

commented Nov 10, 2014

@cirosantilli cool. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.