Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor behaviors.scss constants #8182

Merged
merged 1 commit into from Nov 4, 2014

Conversation

5 participants
@cirosantilli
Copy link
Contributor

commented Oct 27, 2014

2 constants were repeated 4 times: .js-details-container and .js-toggler-container. Let's use our SCSS features to DRY this up.

@TeatroIO

This comment has been minimized.

Copy link

commented Oct 27, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title Factor behaviors.scss constants Factor behaviors.scss constants [failure unrelated] Oct 27, 2014

@Razer6 Razer6 added this to the 7.5 milestone Oct 30, 2014

@axilleas axilleas changed the title Factor behaviors.scss constants [failure unrelated] Factor behaviors.scss constants Nov 1, 2014

vsizov added a commit that referenced this pull request Nov 4, 2014

Merge pull request #8182 from cirosantilli/dry-css-behavior
Factor behaviors.scss constants

@vsizov vsizov merged commit 0269cd3 into gitlabhq:master Nov 4, 2014

1 check passed

default The build passed on Semaphore.
Details
@vsizov

This comment has been minimized.

Copy link
Contributor

commented Nov 4, 2014

thank you

@cirosantilli cirosantilli deleted the cirosantilli:dry-css-behavior branch Nov 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.