New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't output to stdout from lib non-interactive methods [failure unrelated] #8236

Merged
merged 1 commit into from Nov 5, 2014

Conversation

4 participants
@cirosantilli
Contributor

cirosantilli commented Nov 4, 2014

It pollutes the test output too much.

This only affects methods which are called primarily from GitLab's normal operation: lib commands that are triggered by command like actions like Rake tasks were not changed.

Just check for example https://semaphoreapp.com/gitlabhq/gitlabhq/branches/pull-request-8233/builds/1: there are parts of the RSpec where you see nothing but messages like:

Initialized empty Git repository in /home/runner/gitlabhq/tmp/tests/repositories/group336/gitlab.git/

If anyone misses the messages, please patch to log them instead. This can be done with popen as well.

@TeatroIO

This comment has been minimized.

TeatroIO commented Nov 4, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title from Don't output to stdout from lib non-interactive methods to [WIP] Don't output to stdout from lib non-interactive methods Nov 4, 2014

@cirosantilli cirosantilli force-pushed the cirosantilli:rm-lib-stdout branch 2 times, most recently from e8875c4 to 03a88c3 Nov 4, 2014

Don't output to stdout from lib non-interactive methods
It pollutes the test output too much.

@cirosantilli cirosantilli force-pushed the cirosantilli:rm-lib-stdout branch from 03a88c3 to 0b1084a Nov 5, 2014

@cirosantilli cirosantilli changed the title from [WIP] Don't output to stdout from lib non-interactive methods to Don't output to stdout from lib non-interactive methods [failure unrelated] Nov 5, 2014

@Razer6 Razer6 added this to the 7.5 milestone Nov 5, 2014

@vsizov

This comment has been minimized.

Contributor

vsizov commented Nov 5, 2014

it's awesome

vsizov added a commit that referenced this pull request Nov 5, 2014

Merge pull request #8236 from cirosantilli/rm-lib-stdout
Don't output to stdout from lib non-interactive methods [failure unrelated]

@vsizov vsizov merged commit 2b00de7 into gitlabhq:master Nov 5, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:rm-lib-stdout branch Nov 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment