New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused has_gitlab_shell3? method [failure unrelated] #8256

Merged
merged 1 commit into from Dec 21, 2014

Conversation

4 participants
@cirosantilli
Contributor

cirosantilli commented Nov 5, 2014

馃拃

@TeatroIO

This comment has been minimized.

TeatroIO commented Nov 5, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title from Remove unused has_gitlab_shell3? method to Remove unused has_gitlab_shell3? method [failure unrelated] Nov 6, 2014

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Dec 13, 2014

We can only accept a merge requests if all the tests are green, can you please make sure the tests of this merge requests are green? If the failing test has nothing do to with your merge request, you might want to rebase with master to see if that makes the tests green again.

@Razer6

This comment has been minimized.

Member

Razer6 commented Dec 21, 2014

This method was previously used when using gitolite instead of gitlab-shell. Since this change this method is unused.

Razer6 added a commit that referenced this pull request Dec 21, 2014

Merge pull request #8256 from cirosantilli/rm-unused-has_gitlab_shell3
Remove unused has_gitlab_shell3? method

@Razer6 Razer6 merged commit f7f56e4 into gitlabhq:master Dec 21, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:rm-unused-has_gitlab_shell3 branch Dec 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment