New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commit indicator from path on Commits tab [UI] #8324

Merged
merged 1 commit into from Dec 29, 2014

Conversation

5 participants
@cirosantilli
Contributor

cirosantilli commented Nov 16, 2014

After: removed the "commit" after the breadcrumb path:

screenshot from 2014-11-16 17 20 51 after

Before:

I think that "commits" looks weird just a after the breadcrumb as it looks like part of the path, and we are already on the Commits tab, so it is redundant.

@TeatroIO

This comment has been minimized.

TeatroIO commented Nov 16, 2014

I've prepared a stage. Click to open.

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Dec 13, 2014

We can only accept a merge requests if all the tests are green, can you please make sure the tests of this merge requests are green? If the failing test has nothing do to with your merge request, you might want to rebase with master to see if that makes the tests green again.

dzaporozhets added a commit that referenced this pull request Dec 29, 2014

Merge pull request #8324 from cirosantilli/rm-commit
Remove commit indicator from path on Commits tab [UI]

@dzaporozhets dzaporozhets merged commit 86a7787 into gitlabhq:master Dec 29, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:rm-commit branch Dec 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment