-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Check browser version, blacklisting outdated IE versions #8348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I've prepared a stage. Click to open. |
app/views/layouts/admin.html.haml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you not put this inside layouts/flash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes sure, I can move the message inside layout/flash
I put it in a separate file becasue it's not properly a flash message. Anyway, I reckon moving in layout/flash may be a cleaner solution... As you prefer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another option would be to rename flash to something more generic that characterizes both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
Could be a layouts/messages containing something like
= render "layouts/flash"
= render "layouts/outdated_browser" if unsupported_browser?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me.
|
+1 for this idea (haven't reviewed implementation) |
|
I kind of like the orange one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer:
GitLab may not work properly because you are using an outdated web browser. Please install a supported web browser for a better experience.
Specifically click here links in web development are frowned upon and Gitlab should be GitLab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bbodenmiller thanks for suggestion.
Done!
|
Are your screenshots actually from IE6 or IE7. When I put IE11 in IE7 or IE8 document mode I get: If I leave it in IE9+ document mode but set the user agent to IE6 or IE7 then I can see the warning. The real IE6 & IE7 however are going to see what it looks like when IE11 is in those document modes. Point is for IE6, IE7, & IE8 a full screen not support banner needs to be created that we are sure works in those web browsers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for reporting
now it's fixed
|
After @bbodenmiller suggestions here is an updated screenshot (from IE8) |
|
Hmmm... not sure if it is a problem with @TeatroIO but I'm not seeing this on any pages now. |
85271fa to
d2ba6a8
Compare
If a project is being restored, but there is no bundle file, the project was empty when it was backed up. In this case, just use git init --base to create a new bare repository.
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
d2ba6a8 to
30e4334
Compare
app/helpers/emails_helper.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent the right brace the same as the start of the line where the left brace is.
|
I've messed up the history. I'm giong to open a new PR |
|
Please add a link here when you add the new PR. |








Add an alert message in case of outdated browser.
Quite the same as #7597, but implementing a blacklist for ie6 and ie7
Here is a screenshot
