New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify SSH fingerprint regexp extraction #8430

Merged
merged 1 commit into from Jan 15, 2015

Conversation

4 participants
@cirosantilli
Contributor

cirosantilli commented Dec 4, 2014

[\d\h] is the same as \h

@TeatroIO

This comment has been minimized.

TeatroIO commented Dec 4, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title from Simplify SSH fingerprint regexp extraction to Simplify SSH fingerprint regexp extraction [failure unrelated] Dec 5, 2014

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Dec 13, 2014

We can only accept a merge requests if all the tests are green, can you please make sure the tests of this merge requests are green? If the failing test has nothing do to with your merge request, you might want to rebase with master to see if that makes the tests green again.

Simplify SSH fingerprint regexp extraction
[\d\h] is the same as \h

@cirosantilli cirosantilli force-pushed the cirosantilli:simplify-ssh-fingerprint-regex branch from e73f6fd to 5dbe94d Dec 28, 2014

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Dec 28, 2014

@jvanbaarsen rebased. But Semaphore does not want to run?

@cirosantilli cirosantilli changed the title from Simplify SSH fingerprint regexp extraction [failure unrelated] to [WIP] Simplify SSH fingerprint regexp extraction Dec 28, 2014

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Dec 28, 2014

Hmm, seems semaphore run and passed? I'm still baffled by the new merge passed UI.

@cirosantilli cirosantilli changed the title from [WIP] Simplify SSH fingerprint regexp extraction to Simplify SSH fingerprint regexp extraction Dec 28, 2014

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Jan 4, 2015

@cirosantilli Yeah semaphore seems to have passes :-) Marking this as ready for merge! Thanks :)

@jvanbaarsen jvanbaarsen added this to the 7.7 milestone Jan 4, 2015

@dzaporozhets dzaporozhets modified the milestones: 7.7, 7.8 Jan 13, 2015

dzaporozhets added a commit that referenced this pull request Jan 15, 2015

Merge pull request #8430 from cirosantilli/simplify-ssh-fingerprint-r…
…egex

Simplify SSH fingerprint regexp extraction

@dzaporozhets dzaporozhets merged commit 9c4015f into gitlabhq:master Jan 15, 2015

2 checks passed

default The build passed on Semaphore.
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment