Fix for TeamCity buildQueue REST API build/@branchName. #8812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've prepared a stage to preview changes. Open stage or view logs. |
opichals
force-pushed
the
teamcity_branchName_not_to_be_whole_ref
branch
from
7ff854e
to
355371b
Compare
| auth = { | ||
| username: username, | ||
| password: password, | ||
| } | ||
|
|
||
| branch = data[:ref] | ||
| branch = push[:ref].gsub("refs/heads/", "") |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Strips the refs/heads/ if any to get just the branchName out of a :ref e.g.: `refs/heads/feature/newProfile` -> `feature/newProfile` The TeamCity buildQueue POST data require the branchName attribute to contain just the branch name (just xyzbranch and not the full ref in the refs/heads/xyzbranch). With the refs/heads/xyzbranch the build is triggered and looks like it is working however it always ompiles the default branch (or master).
opichals
force-pushed
the
teamcity_branchName_not_to_be_whole_ref
branch
from
355371b
to
008e3d6
Compare
dzaporozhets
added a commit
that referenced
this pull request
Mar 2, 2015
…whole_ref Fix for TeamCity buildQueue REST API build/@branchName.
tigefa4u
pushed a commit
to tigefa4u/gitlabhq
that referenced
this pull request
Jan 3, 2019
…o 'master' Resolve "Follow-up from "Web IDE terminal documentation"" Closes gitlabhq#8812 See merge request gitlab-org/gitlab-ee!8805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strips the refs/*/ if any to get just the branchName out of a :ref
e.g.:
refs/heads/feature/newProfile->feature/newProfileThe TeamCity buildQueue POST data require the branchName attribute
to contain just the branch name (just xyzbranch and not the full
ref in the refs/heads/xyzbranch). With the refs/heads/xyzbranch the
build is triggered and looks like it is working however it always
ompiles the default branch (or master).