Add new feature to find file(recreate) #9889

koreamic · 2015-12-05T09:07:03Z

Using the fuzzy lib, develop "file finder" feature.
(http://feedback.gitlab.com/forums/176466-general/suggestions/4987909-add-file-finder-fuzzy-input-in-files-tab-to-ju)

Issue(#9854)
PR(#9855)

apply ajax request
fuzzy filter(https://github.com/jeancroy/fuzzaldrin-plus)
short cut(when "t" was hitted, go to 'file find' page and 'esc' is to go back)
feature screenshot

(ps. cause by my mistake, recreate PR(#9855), sorry!!)

stanhu · 2015-12-09T06:52:59Z

Great work! I assume since this depends on this gitlab_git MR, this PR has to wait until a new version is release?

Can you add tests for this?

stanhu · 2015-12-12T20:31:45Z

app/controllers/projects/find_file_controller.rb

+  include ExtractsPath
+  include ActionView::Helpers::SanitizeHelper
+  include TreeHelper
+  before_action :assign_ref_vars


Do we also need to add:

before_action :require_non_empty_project before_action :authorize_download_code!

stanhu · 2015-12-12T20:33:53Z

Does this PR also need an upgrade of gitlab_git to 7.2.22?

stanhu · 2015-12-12T20:34:12Z

Also, this feature could use a spinach test to test the JavaScript functionality.

koreamic · 2015-12-12T20:54:08Z

@stanhu
Thank you for your concern and help.

Yes. This PR needs an upgrade of gitlab_git to 7.2.22.

and okay I will check to use a spinach test.

If you need to additional works. please comment.

Thank you. have a nice day.

Razer6 · 2015-12-13T10:12:34Z

app/assets/javascripts/shortcuts_navigation.coffee

@@ -14,6 +14,7 @@ class @ShortcutsNavigation extends Shortcuts
    Mousetrap.bind('g m', -> ShortcutsNavigation.findAndFollowLink('.shortcuts-merge_requests'))
    Mousetrap.bind('g w', -> ShortcutsNavigation.findAndFollowLink('.shortcuts-wiki'))
    Mousetrap.bind('g s', -> ShortcutsNavigation.findAndFollowLink('.shortcuts-snippets'))
+    Mousetrap.bind('t', -> ShortcutsNavigation.findAndFollowLink('.shortcuts-find-file'))


Shouldn't this only be active to on the tree page? Can you also update https://github.com/gitlabhq/gitlabhq/blob/master/app/views/help/_shortcuts.html.haml and the screenshot in https://github.com/gitlabhq/gitlabhq/blob/master/doc/workflow/shortcuts.md

Okay, @Razer6 Thank you for your suggestions.
I updated _shortcuts.html.haml and screenshot.
and I added shortcuts using up and down array key in find file view to select file more conveniently.

The reason that add t shortcut in app/assets/javascripts/shortcuts_navigation.coffee is to use find file view on other page(eg. merge request/commit/branch page) If necessary.

but If not necessary, I just define it on the tree view.

what do you think about that?

I think it doesn't make sense on the issues page, but it does on any file pages (tree, blob, blame) as well as the project root.

koreamic · 2015-12-15T17:53:11Z

@stanhu
I added spinach test case and shortcuts that up down arrow to select item easly.
and modified some bugs(main menu bar out focusing)

please check and review sources

thank you.

yms9654 · 2015-12-17T02:10:55Z

👍 This is a great feature!
I think many users like this.

dzaporozhets · 2015-12-18T16:59:35Z

app/assets/javascripts/lib/fuzzaldrin-plus.js

@@ -0,0 +1,1158 @@
+(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){


Please move this file to /vendor/assets/javascripts

dzaporozhets · 2015-12-18T17:00:40Z

Please provide a screenshots for this feature

stanhu · 2015-12-19T05:41:59Z

app/assets/javascripts/project_find_file.js.coffee

+
+  # make tbody row html
+  makeHtml: (filePath, blobItemUrl) ->
+    return  @row.replace("%blobItemUrl", blobItemUrl).replace("%filePath", filePath)


What happens if the file path has the text %blobItemUrl? Can we just construct the entire text without a replace?

As mentioned above, please generate the row DOM using jQuery.

DouweM · 2016-01-05T14:48:01Z

app/assets/javascripts/project_find_file.js.coffee

+    $(".tree-table > tbody").empty()
+
+    for filePath, i in filePaths
+      break if i > 19


So if i == 20? :) That may be a little clearer.

DouweM · 2016-01-05T15:02:49Z

@koreamic I may seem very critical (and I am), but I tried it out locally and it works really, really well. Great job. I can't wait to have this in the next release :) I'm sure we can get it ready.

koreamic · 2016-01-07T06:41:04Z

@DouweM
I have to thank you for your review and concern all the time.
I have learned many things.
I modified sources and commited as your review.
but If there are things to be modified, leave comments.

Using the fuzzy filter, develop "file finder" feature. - feedback(http://feedback.gitlab.com/forums/176466-general/suggestions/4987909-add-file-finder-fuzzy-input-in-files-tab-to-ju ) - fuzzy filter(https://github.com/jeancroy/fuzzaldrin-plus) - shortcuts(when "t" was hitted at tree view, go to 'file find' page and 'esc' is to go back) - depends on gitlab_git 7.2.22

DouweM · 2016-01-07T11:48:14Z

@koreamic You're amazing. I've got nothing, I'm merging this.

Add new feature to find file(recreate)

JobV · 2016-01-07T12:02:09Z

This is awesome. Thanks @koreamic

DouweM · 2016-01-07T12:05:07Z

@koreamic I notice you're not credited in the changelog! I added (koreamic) in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2327, let me know if you want that to have your full name instead.

Razer6 · 2016-01-07T13:46:43Z

❤️

stanhu · 2016-01-07T13:59:24Z

Great work, @koreamic!

koreamic · 2016-01-07T15:43:13Z

@DouweM @stanhu @Razer6 @randx @JobV @yms9654 @noveler17
Thanks a lot for your help & patience.
@DouweM koreamic is enough. thanks

dzaporozhets · 2016-01-07T17:13:04Z

@koreamic can you please provide us with your full name? We prefer not to use usernames since it can be different between websites and can produce unnecessary confusion. cc @DouweM

dzaporozhets · 2016-01-07T17:13:25Z

@koreamic and thank you for getting this feature done! 👍 ✨

koreamic · 2016-01-08T02:22:08Z

@randx @DouweM
Okay. My full name is Kyungchul Shin
Thank you.

dzaporozhets · 2016-01-08T09:58:24Z

@koreamic thank you!

@DouweM I will update CHANGELOG

dzaporozhets · 2016-01-08T09:59:56Z

wow @stanhu already updated CHANGELOG 😄 🚀

rspeicher · 2016-01-17T20:31:22Z

@koreamic Curious, why did you use fuzzaldrin-plus instead of fuzzaldrin? And which version was it?

DouweM · 2016-01-17T20:36:44Z

@tsigo That was at my suggestion actually. I had much better results in Atom's fuzzy finder with the "Use Alternate Scoring" option enabled, which switches from fuzzaldrin to fuzzaldrin-plus. It's now the default in Atom's fuzzy finder as well: atom/fuzzy-finder@c004c7e

rspeicher · 2016-01-17T20:38:18Z

Ok. Do we know which version it was? I'm trying to replace the minified vendor JS with non-minified versions (specifically so we know version info, among other things).

DouweM · 2016-01-17T20:39:42Z

@tsigo Ah, good call. It doesn't really matter, the API hasn't changed, so you can just get the latest one.

@DouweM

Added function ls_files in Gitlab::Git::Repository Using native git command(git ls-tree) ls_files function ls to return only each file's full paths of a repository This function is called by Repository within GitLab as @DouweM 's suggestion. (ref : gitlabhq/gitlabhq#9889 & https://github.com/gitlabhq/gitlabhq#9855) See merge request !60

koreamic mentioned this pull request Dec 7, 2015

Added function ls_files in Gitlab::Git::Repository gitlabhq/gitlab_git#64

Closed

stanhu reviewed Dec 12, 2015
View changes

Razer6 reviewed Dec 13, 2015
View changes

dzaporozhets reviewed Dec 18, 2015
View changes

stanhu reviewed Dec 19, 2015
View changes

DouweM reviewed Jan 5, 2016
View changes

DouweM added a commit that referenced this issue Jan 7, 2016

Merge pull request #9889 from koreamic/file_finder

5c7de85

Add new feature to find file(recreate)

DouweM merged commit 5c7de85 into gitlabhq:master Jan 7, 2016
1 check passed

gitlabhq deleted a comment Jul 7, 2021

gitlabhq / gitlabhq Public

Add new feature to find file(recreate) #9889

Add new feature to find file(recreate) #9889

koreamic commented Dec 5, 2015

stanhu commented Dec 9, 2015

stanhu Dec 12, 2015

stanhu commented Dec 12, 2015

stanhu commented Dec 12, 2015

koreamic commented Dec 12, 2015

Razer6 Dec 13, 2015

koreamic Dec 15, 2015

DouweM Dec 22, 2015

koreamic commented Dec 15, 2015

yms9654 commented Dec 17, 2015

dzaporozhets Dec 18, 2015

dzaporozhets commented Dec 18, 2015

stanhu Dec 19, 2015

DouweM Dec 22, 2015

DouweM Jan 5, 2016

DouweM commented Jan 5, 2016

koreamic commented Jan 7, 2016

DouweM commented Jan 7, 2016

JobV commented Jan 7, 2016

DouweM commented Jan 7, 2016

Razer6 commented Jan 7, 2016

stanhu commented Jan 7, 2016

koreamic commented Jan 7, 2016

dzaporozhets commented Jan 7, 2016

dzaporozhets commented Jan 7, 2016

koreamic commented Jan 8, 2016

dzaporozhets commented Jan 8, 2016

dzaporozhets commented Jan 8, 2016

rspeicher commented Jan 17, 2016

DouweM commented Jan 17, 2016

rspeicher commented Jan 17, 2016

DouweM commented Jan 17, 2016

		@@ -0,0 +1,1158 @@
		(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){

gitlabhq / gitlabhq Public

Add new feature to find file(recreate) #9889

Add new feature to find file(recreate) #9889

Conversation

koreamic commented Dec 5, 2015

stanhu commented Dec 9, 2015

Choose a reason for hiding this comment

stanhu commented Dec 12, 2015

stanhu commented Dec 12, 2015

koreamic commented Dec 12, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

koreamic commented Dec 15, 2015

yms9654 commented Dec 17, 2015

Choose a reason for hiding this comment

dzaporozhets commented Dec 18, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DouweM commented Jan 5, 2016

koreamic commented Jan 7, 2016

DouweM commented Jan 7, 2016

JobV commented Jan 7, 2016

DouweM commented Jan 7, 2016

Razer6 commented Jan 7, 2016

stanhu commented Jan 7, 2016

koreamic commented Jan 7, 2016

dzaporozhets commented Jan 7, 2016

dzaporozhets commented Jan 7, 2016

koreamic commented Jan 8, 2016

dzaporozhets commented Jan 8, 2016

dzaporozhets commented Jan 8, 2016

rspeicher commented Jan 17, 2016

DouweM commented Jan 17, 2016

rspeicher commented Jan 17, 2016

DouweM commented Jan 17, 2016