Skip to content

Conversation

@huacnlee
Copy link
Contributor

More detail see #9963

I have changed it on my production environment, no error happen now.

@huacnlee
Copy link
Contributor Author

2016-01-12 17 13 48

@huacnlee
Copy link
Contributor Author

references link:
ruby/ruby@238b979

@DouweM
Copy link
Contributor

DouweM commented Jan 12, 2016

@huacnlee Looks great, thanks! I'll merge once the build goes green.

@huacnlee
Copy link
Contributor Author

Do you need me to cherry-pick the commits and create a new PR for master?
Or you direct merge it to master after review?

@DouweM
Copy link
Contributor

DouweM commented Jan 12, 2016

@huacnlee Ah, good point. Yes, please create a new PR for master, we will pick it into 8-3-stable ourselves. Would you mind creating it on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests? That way we get the canonical set of test builds, instead of just semaphore :)

@DouweM
Copy link
Contributor

DouweM commented Jan 12, 2016

I will close this PR and wait for one to master.

@DouweM DouweM closed this Jan 12, 2016
@huacnlee
Copy link
Contributor Author

Ok, I see.

stanhu pushed a commit that referenced this pull request Jan 13, 2016
…'master'


Fix #9963 reference_filter "Encoding::CompatibilityError" bug with some complex URL;

#9964

@DouweM

See merge request !2383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants