Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix the travis CI build. #4

Merged
merged 1 commit into from

2 participants

@nathanvda

I do not completely understand. I merged in the gitlabhq-changes, since then I had to adapt the test to 7, apparently it fails on ci, so I restore it to 4. I will need to check my fixtures here why my count could be different.

@nathanvda

Ok, I get it. It took me a while :) It is counting the remotes from the grit-project itself. Since I originally forked from mojombo/grit, that is my origin. To pull in your changes, I had to add gitlabhq/grit as a remote. Since there are three branches in each remote (no_raw_git, master and patch_id), plus the default origin/HEAd gives me seven remotes, while of course, on your repo there is only 4. Hehe. Nice to be able to finally explain it.

For now the fix is good enough I think. In the future I might use a fixture instead.

@randx randx merged commit 7f35cb9 into gitlabhq:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 13, 2012
  1. @nathanvda

    Fix build on ci.

    nathanvda authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  test/test_remote.rb
View
2  test/test_remote.rb
@@ -13,6 +13,6 @@ def test_inspect
end
def test_remote_count
- assert_equal 7, @r.remote_count
+ assert_equal 4, @r.remote_count
end
end
Something went wrong with that request. Please try again.