Skip to content

gitlab_projects(s): Add suggestion_commit_message #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

pascal-hofmann
Copy link
Contributor

@pascal-hofmann pascal-hofmann commented Sep 15, 2022

Edit: I just noticed that I mixed up the field names in my initial commit message. This is fixed now. 😓🙈

Description

Closes #1248.

PR Checklist Acknowledgement

  • I acknowledge that all of the following items are true, where applicable:
    • Resource attributes match 1:1 the names and structure of the API resource in the GitLab API documentation.
    • Examples are updated with:
      • A *.tf file for the resource/s with at least one usage example
      • A *.sh file for the resource/s with an import example (if applicable)
    • New resources have at minimum a basic test with three steps:
      • Create the resource
      • Update the attributes
      • Import the resource
    • No new //lintignore comments were copied from existing code. (Linter rules are meant to be enforced on new code.)

@github-actions github-actions bot added data-source Adds or modifies a data-source documentation provider resource Adds or modifies a resource tests size/S labels Sep 15, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @pascal-hofmann 👋

It looks like this is your first submission to the Terraform GitLab Provider! If you haven’t already done so, please make sure you have checked out our CONTRIBUTING.md guide to make sure your contribution has all the necessary elements in place for a successful approval.

Thanks again, and welcome to the community! 😃

@pascal-hofmann pascal-hofmann marked this pull request as ready for review September 15, 2022 13:12
@pascal-hofmann pascal-hofmann changed the title gitlab_projects(s): Add squash_commit_template gitlab_projects(s): Add suggestion_commit_message Sep 15, 2022
@timofurrer timofurrer added this to the v3.19.0 milestone Sep 16, 2022
Copy link
Member

@timofurrer timofurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @pascal-hofmann 🌮

LGTM 🚢

@github-actions
Copy link

Marking this pull request as stale due to 30 days of inactivity. If this pull request receives no comments in the next 14 days it will be closed. Maintainers can also remove the stale label.

To help this pull request get reviewed, please check that it is rebased onto the latest main and is passing automated checks. It also helps if you could reference an issue that the pull request resolves, and create one if it doesn't exist.

@github-actions github-actions bot added the stale label Oct 17, 2022
@pascal-hofmann
Copy link
Contributor Author

This PR is not stale and already reviewed / approved.

@timofurrer timofurrer merged commit 2f06bac into gitlabhq:main Oct 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
data-source Adds or modifies a data-source documentation provider resource Adds or modifies a resource size/S stale tests
Development

Successfully merging this pull request may close these issues.

2 participants