Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation errors for symfony/process v3.x #138

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@iwazaru
Copy link

iwazaru commented Mar 11, 2019

Fixes #131

@GrahamCampbell

This comment has been minimized.

Copy link
Collaborator

GrahamCampbell commented Mar 11, 2019

This breaks support for older versions, such as 2.8.x.

@lyrixx

This comment has been minimized.

Copy link
Member

lyrixx commented Mar 12, 2019

IMHO, we can drop support for old SF version.
But before that we need to tag a new release

@iwazaru

This comment has been minimized.

Copy link
Author

iwazaru commented Mar 12, 2019

I've started to work on a fix for but I'm having difficulties with PHP 5.3 installation. Tell me if I can drop it. Although I will need support for PHP 5.6 (and thus process 3.X).

@lyrixx

This comment has been minimized.

Copy link
Member

lyrixx commented Mar 12, 2019

you can drop all 5.X PHP version 👍

@iwazaru

This comment has been minimized.

Copy link
Author

iwazaru commented Mar 12, 2019

Do you mean all 5.X versions before 5.6? As I said I need PHP 5.6 support. And you don't need this fix if you don't support 5.6 anyway.

@iwazaru

This comment has been minimized.

Copy link
Author

iwazaru commented Mar 12, 2019

Also, what about HHVM? The build seems to fail at the composer install step but I didn't make any change to the composer.json file.

@lyrixx

This comment has been minimized.

Copy link
Member

lyrixx commented Mar 12, 2019

You can rebase to get ride of hhvm. About 5.6 it's up to you. It's eol'ed for a while so...

lyrixx and others added some commits Nov 28, 2018

@iwazaru

This comment has been minimized.

Copy link
Author

iwazaru commented Mar 12, 2019

Thanks! I'm struggling to get rid of PHP 5.6 but I'm not there yet.

@iwazaru iwazaru changed the title Fix depreciation errors for symfony/process v3.x Fix deprecation errors for symfony/process v3.x Mar 12, 2019

@lyrixx

lyrixx approved these changes Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.