Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rudimentary methods for writing data #166

Open
wants to merge 29 commits into
base: master
from

Conversation

@chris-kruining
Copy link

chris-kruining commented Mar 16, 2020

I know this does probably not cover all use cases, but this does allow to simple staging and committing of files

I know this does probably not cover all use cases, but this does allow to simple staging and committing of files
@lyrixx
lyrixx approved these changes Mar 18, 2020
@alexandresalome

This comment has been minimized.

Copy link
Member

alexandresalome commented Mar 19, 2020

Hello @chris-kruining

Thank you for your contribution.

Regarding the stage/unstage/discard/commit methods, could you move them to the WorkingCopy class? The working copy is about the files checked out in directory for edition.

For the push/pull method, they can stay, I think, on the Repository.

After that, could you add at least documentation, and ideally tests?

Copy link
Member

GrahamCampbell left a comment

no clue
I am blanking on how to test behaviour on a method that is essentially void
doc/workingcopy.md Outdated Show resolved Hide resolved
@chris-kruining chris-kruining requested a review from GrahamCampbell Mar 19, 2020
src/Gitonomy/Git/Repository.php Outdated Show resolved Hide resolved
doc/repository.md Outdated Show resolved Hide resolved
doc/repository.md Outdated Show resolved Hide resolved
doc/workingcopy.md Outdated Show resolved Hide resolved
GrahamCampbell and others added 4 commits Mar 20, 2020
Co-Authored-By: Alexandre Salomé <github@pub.salome.fr>
Co-Authored-By: Alexandre Salomé <github@pub.salome.fr>
Co-Authored-By: Alexandre Salomé <github@pub.salome.fr>
src/Gitonomy/Git/Repository.php Show resolved Hide resolved
src/Gitonomy/Git/Repository.php Show resolved Hide resolved
Copy link
Member

GrahamCampbell left a comment

I've made some corrections, however the tests still need some work. :)

@GrahamCampbell GrahamCampbell changed the title rudimentary methods for writing data Added rudimentary methods for writing data Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.