Skip to content

Add golangci#24

Merged
rl-gitpod merged 1 commit into
mainfrom
rl/add-golangci
Jun 15, 2021
Merged

Add golangci#24
rl-gitpod merged 1 commit into
mainfrom
rl/add-golangci

Conversation

@rl-gitpod
Copy link
Copy Markdown
Contributor

@rl-gitpod rl-gitpod commented Jun 11, 2021

Fix issue reported by staticcheck

VSCode does not report that the linter specified in the config is not present i.e. fails silently.

Gitpod's dev image has golangci installed but workspace-full, on which this repo depends, does not. PR to fix that here

Fix issue reported by staticcheck
@rl-gitpod rl-gitpod requested a review from csweichel June 11, 2021 03:15
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 11, 2021

Codecov Report

Merging #24 (212c780) into main (1937dff) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   12.05%   12.05%           
=======================================
  Files           4        4           
  Lines         871      871           
=======================================
  Hits          105      105           
  Misses        747      747           
  Partials       19       19           
Impacted Files Coverage Δ
pkg/dazzle/build.go 4.48% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1937dff...212c780. Read the comment docs.

Copy link
Copy Markdown
Collaborator

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rl-gitpod rl-gitpod merged commit 9513b93 into main Jun 15, 2021
@rl-gitpod rl-gitpod deleted the rl/add-golangci branch June 15, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants