[linting] Enable eslint/no-unsafe-argument (#18965)

Author: svenefftinge

components/gitpod-db/.eslintrc

@@ -10,13 +10,15 @@
     },
     "rules": {
         "no-var": "error",
+        "no-void": "error",
         "prefer-const": "error",
         "@typescript-eslint/ban-ts-comment": "off",
         "@typescript-eslint/ban-types": "off",
         "@typescript-eslint/explicit-module-boundary-types": "off",
         "@typescript-eslint/no-empty-function": "off",
         "@typescript-eslint/no-empty-interface": "off",
         "@typescript-eslint/no-explicit-any": "off",
+        "@typescript-eslint/no-floating-promises": "error",
         "@typescript-eslint/no-non-null-asserted-optional-chain": "off",
         "@typescript-eslint/no-inferrable-types": "off",
         "@typescript-eslint/no-misused-promises": [
@@ -28,6 +30,7 @@
         "@typescript-eslint/no-namespace": "off",
         "@typescript-eslint/no-non-null-assertion": "off",
         "@typescript-eslint/no-this-alias": "off",
+        "@typescript-eslint/no-unsafe-argument": "error",
         "@typescript-eslint/no-unused-vars": [
             "error",
             {

components/gitpod-db/src/migrate-migrations.ts

@@ -7,6 +7,7 @@
 import { TypeORM } from "./typeorm/typeorm";
 import { Config } from "./config";
 import { MigrateMigrations0_2_0 } from "./typeorm/migrate-migrations-0_2_0";
+import { log } from "@gitpod/gitpod-protocol/lib/util/logging";
 
 async function migrateMigrationsTable() {
     const config = new Config();
@@ -17,7 +18,7 @@ async function migrateMigrationsTable() {
     const migration_0_2_0 = new MigrateMigrations0_2_0();
     await migration_0_2_0.up(runner);
 
-    conn.close();
+    conn.close().catch((err) => log.error("cannot close connection", err));
     console.log("successfully migrated 'migrations' table.");
 }
 

components/gitpod-db/src/periodic-deleter.ts

@@ -39,18 +39,13 @@ export class PeriodicDbDeleter {
         const pendingDeletions: Promise<void>[] = [];
         for (const { deletions } of toBeDeleted.reverse()) {
             for (const deletion of deletions) {
-                pendingDeletions.push(
-                    this.query(deletion).catch((err) =>
-                        log.error(
-                            `[PeriodicDbDeleter] sync error`,
-                            {
-                                periodicDeleterTickId: tickID,
-                                query: deletion,
-                            },
-                            err,
-                        ),
-                    ),
+                const promise: Promise<void> = this.query(deletion).catch((err) =>
+                    log.error(`[PeriodicDbDeleter] sync error`, err, {
+                        periodicDeleterTickId: tickID,
+                        query: deletion,
+                    }),
                 );
+                pendingDeletions.push(promise);
             }
         }
         await Promise.all(pendingDeletions);

components/gitpod-db/src/redis/publisher.spec.ts

@@ -31,8 +31,8 @@ class TestRedisPublisher {
 
     @test public publishInstanceUpdate() {
         const publisher = this.container.get(RedisPublisher);
-        expect(() => {
-            publisher.publishInstanceUpdate({
+        expect(async () => {
+            await publisher.publishInstanceUpdate({
                 ownerID: "123-owner",
                 instanceID: "123",
                 workspaceID: "foo-bar-123",

components/gitpod-db/src/tables.spec.ts

@@ -19,11 +19,7 @@ class TablesSpec {
     @test(timeout(10000))
     public async createAndFindATeam() {
         const thing = new GitpodTableDescriptionProvider();
-        try {
-            thing.getSortedTables();
-        } catch (error) {
-            expect.fail(error);
-        }
+        expect(() => thing.getSortedTables()).to.not.throw();
     }
 }
 

components/gitpod-db/src/test/reset-db.ts

@@ -12,7 +12,7 @@ export async function resetDB(typeorm: TypeORM) {
     const conn = await typeorm.getConnection();
     const users = await conn.getRepository(DBUser).find();
     // delete all users except the builtin users
-    conn.getRepository(DBUser).remove(users.filter((u) => !isBuiltinUser(u.id)));
+    await conn.getRepository(DBUser).remove(users.filter((u) => !isBuiltinUser(u.id)));
 
     const deletions = conn.entityMetadatas
         .filter((meta) => meta.tableName !== "d_b_user")

components/gitpod-db/src/traced-db.ts

@@ -17,6 +17,7 @@ export class DBWithTracing<T> {
     public trace(ctx: TraceContext): T {
         return new Proxy(this.db, {
             get: (_target: any, name: string) => {
+                // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
                 const f = Reflect.get(_target, name);
                 if (!f) {
                     return undefined;

components/gitpod-db/src/typeorm/team-db-impl.ts

@@ -254,7 +254,7 @@ export class TeamDBImpl extends TransactionalDBImpl<TeamDB> implements TeamDB {
         const orgSettings = await orgSettingsRepo.findOne({ where: { orgId } });
         if (orgSettings) {
             orgSettings.deleted = true;
-            orgSettingsRepo.save(orgSettings);
+            await orgSettingsRepo.save(orgSettings);
         }
     }
 

components/gitpod-db/src/typeorm/transformer.ts

@@ -64,6 +64,7 @@ export namespace Transformer {
         },
         from(value: any): any {
             // From TIMESTAMP to ISO string
+            // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
             return new Date(Date.parse(value)).toISOString();
         },
     };
@@ -74,6 +75,7 @@ export namespace Transformer {
                 return JSON.stringify(value || defaultValue);
             },
             from(value: any): any {
+                // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
                 return JSON.parse(value);
             },
         };
@@ -85,6 +87,7 @@ export namespace Transformer {
                 return encryptionServiceProvider().encrypt(value);
             },
             from(value: any): any {
+                // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
                 return encryptionServiceProvider().decrypt(value);
             },
         };

components/gitpod-db/src/typeorm/user-db-impl.ts

@@ -379,6 +379,7 @@ export class TypeORMUserDBImpl extends TransactionalDBImpl<UserDB> implements Us
         }
         const res = await userRepo.query(query);
         const count = res[0].cnt;
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         return Number.parseInt(count);
     }
 
@@ -598,7 +599,7 @@ export class TypeORMUserDBImpl extends TransactionalDBImpl<UserDB> implements Us
     }
     async revoke(accessTokenToken: OAuthToken): Promise<void> {
         const tokenHash = crypto.createHash("sha256").update(accessTokenToken.accessToken, "utf8").digest("hex");
-        this.deleteGitpodToken(tokenHash);
+        await this.deleteGitpodToken(tokenHash);
     }
     async isRefreshTokenRevoked(refreshToken: OAuthToken): Promise<boolean> {
         return Date.now() > (refreshToken.refreshTokenExpiresAt?.getTime() ?? 0);