Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Gracefully handle connection disposal #5042

Closed
shaal opened this issue Aug 2, 2021 · 6 comments · Fixed by #5787 or #6006
Closed

[dashboard] Gracefully handle connection disposal #5042

shaal opened this issue Aug 2, 2021 · 6 comments · Fixed by #5787 or #6006
Assignees
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: bug Something isn't working

Comments

@shaal
Copy link
Contributor

shaal commented Aug 2, 2021

Bug description

Loading a workspace took very long time, at the end I got this:
image

Steps to reproduce

It happened only once; But I've never seen it before.
I was able to open the URL in a new tab and it worked as expected.

This is the URL:
https://gitpod.io/#DP_PROJECT_NAME=feeds_ex,DP_ISSUE_FORK=feeds_ex-3025848,DP_ISSUE_BRANCH=3025848-context-examples-with-code,DP_PROJECT_TYPE=project_module,DP_MODULE_VERSION=8.x-1.x,DP_CORE_VERSION=9.2.0,DP_PATCH_FILE=,DP_INSTALL_PROFILE=standard/https://github.com/shaal/drupalpod

Expected behavior

It would be awesome to know what is going on while it's happening, why a workspace takes long, what part of it got stuck, is it something I did wrong, or a glitch in the system. I'm just happy it only happened once :)

Example repository

https://gitpod.io/#DP_PROJECT_NAME=feeds_ex,DP_ISSUE_FORK=feeds_ex-3025848,DP_ISSUE_BRANCH=3025848-context-examples-with-code,DP_PROJECT_TYPE=project_module,DP_MODULE_VERSION=8.x-1.x,DP_CORE_VERSION=9.2.0,DP_PATCH_FILE=,DP_INSTALL_PROFILE=standard/https://github.com/shaal/drupalpod

Anything else?

No response

@jankeromnes
Copy link
Contributor

Hi @shaal! Thanks for raising this issue. 😁

I believe that "Connection got disposed" is an error that typically gets logged by the front-end when it cannot reach the back-end at all (e.g. when there is an Internet outage, or even a brief network flake out).

I was able to reproduce it by loading the dashboard, then turning off my laptop wifi, and then trying to navigate to a different page & back.

@akosyakov
Copy link
Member

akosyakov commented Aug 3, 2021

Probably dashboard should handle reconnections more gracefully. As far as I know the global load balancer drops web sockets each 10 mins, so it does not even need to be an issue on the client side.

@akosyakov
Copy link
Member

I got the same today as well.

@akosyakov akosyakov added component: dashboard type: bug Something isn't working labels Aug 7, 2021
@csweichel csweichel changed the title Connection got disposed. [dashboard] Gracefully handle connection disposal Aug 9, 2021
@csweichel
Copy link
Contributor

/schedule

@JanKoehnlein JanKoehnlein reopened this Aug 9, 2021
@csweichel csweichel added the team: webapp Issue belongs to the WebApp team label Aug 24, 2021
@rl-gitpod rl-gitpod self-assigned this Aug 31, 2021
@rl-gitpod
Copy link
Contributor

/unassign

@AlexTugarev
Copy link
Member

Looking at the code this is not a websocket connection issue at all.

That error is propagated from server to the frontend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: bug Something isn't working
Projects
None yet
10 participants