Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team Subscription UI fixes #11205

Merged
merged 3 commits into from Jul 8, 2022
Merged

Team Subscription UI fixes #11205

merged 3 commits into from Jul 8, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Jul 7, 2022

Description

This PR fixes two issues:

  1. "Teams" UI no longer displays slots from multiple Team Subscriptions, but used the id to match them correctly
  2. Do not forward "deleted" Team Subscriptions from the DB.
  3. User Details: filter out deleted subscriptions

Related Issue(s)

Fixes #11203

How to test

Not sure how to test: I'd argue we should thoroughly review the diff and judge based on that.

Release Notes

two fixes the old Team Subscription UI

Documentation

Werft options:

  • /werft with-preview

@geropl geropl requested a review from a team July 7, 2022 13:43
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 7, 2022
@roboquat roboquat added size/S and removed size/XS labels Jul 7, 2022
@roboquat roboquat merged commit 4782998 into main Jul 8, 2022
@roboquat roboquat deleted the gpl/11203-tss branch July 8, 2022 06:23
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
3 participants