Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kots]: put the "run" collectors into the active namespace #11698

Merged
merged 1 commit into from Jul 27, 2022
Merged

[kots]: put the "run" collectors into the active namespace #11698

merged 1 commit into from Jul 27, 2022

Conversation

mrsimonemms
Copy link
Contributor

Description

The KOTS run collectors previously ran in the default namespace. This puts them in the namespace where the application is stored

How to test

Deploy via KOTS

Release Notes

[kots]: put the "run" collectors into the active namespace

Documentation

Werft options:

  • /werft with-preview

@mrsimonemms mrsimonemms requested a review from a team July 27, 2022 13:57
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Jul 27, 2022
adrienthebo
adrienthebo approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@adrienthebo adrienthebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roboquat roboquat merged commit 183c9d6 into main Jul 27, 2022
@roboquat roboquat deleted the sje/kots-checks-ns branch July 27, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrienthebo adrienthebo adrienthebo approved these changes

Assignees
No one assigned
Labels
release-note size/XS team: delivery Issue belongs to the self-hosted team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrsimonemms @adrienthebo @roboquat