Skip to content

[bridge] Fix logging #12988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2022
Merged

[bridge] Fix logging #12988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions components/ws-manager-bridge/src/bridge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,12 +518,12 @@ export class WorkspaceManagerBridge implements Disposable {
instance.stoppingTime &&
durationLongerThanSeconds(Date.parse(instance.stoppingTime), 10))
) {
log.info("Logging to validate #12902. Should mark as stopped in database.", {
instanceId,
workspaceId: instance.workspaceId,
installation,
phase,
});
log.info(
Copy link
Member

@easyCZ easyCZ Sep 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that our typechecking is not catching these..

Copy link
Member

@geropl geropl Sep 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are correct, type-wise and semantically. 🤷

{ instanceId, workspaceId: instance.workspaceId },
"Logging to validate #12902. Should mark as stopped in database.",
{ installation },
{ phase },
);
}
log.debug({ instanceId }, "Skipping instance", {
phase: instance.status.phase,
Expand Down