Skip to content

Conversation

@geropl
Copy link
Member

@geropl geropl commented Nov 27, 2023

Description

Reverts this line: https://github.com/gitpod-io/gitpod/pull/19097/files#diff-4a5c8bb479a125673053c7e43fe340a3bb1ffb478115a0003ae497c5005a1dcdL108

Summary generated by Copilot

🤖[deprecated] Generated by Copilot at da23c35

Fix bug in rendering inactive workspaces section in dashboard. Use correct variable to check for inactive workspaces in Workspaces.tsx.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to unblock

@geropl
Copy link
Member Author

geropl commented Nov 27, 2023

/unblock

@geropl
Copy link
Member Author

geropl commented Nov 27, 2023

/unhold

@geropl
Copy link
Member Author

geropl commented Nov 27, 2023

/unsomething

@geropl
Copy link
Member Author

geropl commented Nov 27, 2023

/unummmmh

@roboquat roboquat merged commit c25da39 into main Nov 27, 2023
@roboquat roboquat deleted the gpl/revert-ws-inactive branch November 27, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants