Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-daemon] Filter tasks log if the file does not exists #4996

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 28, 2021

fix #4952 is not enough because the error is wrapped

Test:

  • Open a workspace
  • Check ws-daemon log and check there is no "cannot read tasks file" error

@roboquat roboquat requested a review from csweichel July 28, 2021 18:49
@aledbf
Copy link
Member Author

aledbf commented Jul 28, 2021

/assign @csweichel

@csweichel
Copy link
Contributor

/lgtm
/approve no-issue

@roboquat roboquat added the lgtm label Jul 28, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7c002c6d1122fd50f081a99ae5a8059a4d048cf4

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, csweichel

Associated issue: #4952

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #4996 (439378f) into main (5b15f69) will increase coverage by 22.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #4996       +/-   ##
=========================================
+ Coverage      0   22.15%   +22.15%     
=========================================
  Files         0       13       +13     
  Lines         0     2103     +2103     
=========================================
+ Hits          0      466      +466     
- Misses        0     1575     +1575     
- Partials      0       62       +62     
Flag Coverage Δ
components-ws-daemon-app 22.15% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-daemon/pkg/resources/controller.go 33.93% <0.00%> (ø)
components/ws-daemon/pkg/quota/mounts.go 53.19% <0.00%> (ø)
components/ws-daemon/pkg/content/tar.go 45.63% <0.00%> (ø)
...onents/ws-daemon/pkg/internal/session/workspace.go 50.73% <0.00%> (ø)
components/ws-daemon/pkg/content/config.go 62.50% <0.00%> (ø)
components/ws-daemon/pkg/quota/size.go 87.30% <0.00%> (ø)
components/ws-daemon/pkg/content/service.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/quota/sandbox_linux.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/content/archive.go 57.47% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b15f69...439378f. Read the comment docs.

@roboquat roboquat merged commit 55bf25e into main Jul 28, 2021
@roboquat roboquat deleted the aledbf/fixwrap branch July 28, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants