[server] Fold in https://github.com/gitpod-io/gitpod-yml-inferrer #5503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve no-issue 馃憤 started the job as gitpod-build-jx-fold-in-inferrer.4 |
|
Would have been good to assign #5471 馃槵 |
svenefftinge
approved these changes
Sep 2, 2021
|
LGTM label has been added. Git tree hash: ec82dfcf38e81abe648dba2814153f65032bc622
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jankeromnes, svenefftinge Associated issue requirement bypassed by: jankeromnes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Oops, oh no! Sorry for the cross-fire 馃檲 EDIT: I hadn't even seen that issue. 馃槼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Folds in https://github.com/gitpod-io/gitpod-yml-inferrer instead of using it as an NPM module, fixing #5438 (comment)
And Gitpod even recognizes & runs the unit tests! 馃
/approve no-issue
/uncc
/cc @svenefftinge
/cc @csweichel
EDIT: Fixes #5471