GCP object storage bugfixes #6636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
do-not-merge/work-in-progress
do-not-merge/release-note-label-needed
team: webapp
Codecov Report
@@ Coverage Diff @@
## main #6636 +/- ##
==========================================
+ Coverage 32.74% 37.08% +4.34%
==========================================
Files 122 85 -37
Lines 22193 16656 -5537
==========================================
- Hits 7266 6177 -1089
+ Misses 14309 9997 -4312
+ Partials 618 482 -136
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mrsimonemms
force-pushed
the
sje/gke-obj-storage
branch
2 times, most recently
from
973e50c
to
5dcaeaa
Compare
mrsimonemms
force-pushed
the
sje/gke-obj-storage
branch
from
5dcaeaa
to
ee9df67
Compare
mrsimonemms
commented
Nov 10, 2021
| @@ -23,6 +23,68 @@ func deployment(ctx *common.RenderContext) ([]runtime.Object, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| podSpec := corev1.PodSpec{ | |||
There was a problem hiding this comment.
Although this looks a big change, it's "just" copy/pasta so can put the AddStorageMounts in
|
/assign @csweichel |
csweichel
reviewed
Nov 11, 2021
mrsimonemms
force-pushed
the
sje/gke-obj-storage
branch
2 times, most recently
from
b0d847c
to
2ead0b1
Compare
mrsimonemms
force-pushed
the
sje/gke-obj-storage
branch
from
2ead0b1
to
20e0632
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: aa6b7dcbe53d632525f3e3c5c2c7dd032179ec84
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue: #6621 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
minio.<domain>from proxy if using GCP cloud storagestorageConfigurationfunction in common modulemetadata.regionto belocal. Enforce this value in the storage configuration if using Minio - I've found that if the config value is notlocal, it causes connectivity issues.Related Issue(s)
Fixes #
How to test
Create a service account with
"roles/storage.adminandroles/storage.objectAdminroles and create a secret:Deploy using config:
Ensure that incluster config is fine by running
objectStorage.inCluster: trueRelease Notes
Documentation