Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jetbrains] Add PhpStorm IDE #7059

Merged
merged 1 commit into from
Dec 6, 2021
Merged

[jetbrains] Add PhpStorm IDE #7059

merged 1 commit into from
Dec 6, 2021

Conversation

corneliusludmann
Copy link
Contributor

Description

Another day, another IDE. I just had a few minutes and added PhpStorm. Short smoke test looked good so far.

How to test

Go to preferences and choose PhpStorm.

Release Notes

Add PhpStorm desktop IDE.

Documentation

Docs need to be updated. Issue follows soon.

@roboquat roboquat added release-note team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team size/M labels Dec 3, 2021
@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #7059 (7bd3ce7) into main (5837426) will decrease coverage by 26.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #7059       +/-   ##
==========================================
- Coverage   32.62%   5.84%   -26.79%     
==========================================
  Files           6      13        +7     
  Lines        1128    1147       +19     
==========================================
- Hits          368      67      -301     
- Misses        724    1079      +355     
+ Partials       36       1       -35     
Flag Coverage Δ
components-image-builder-mk3-app ?
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 5.84% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ents/image-builder-mk3/pkg/orchestrator/metrics.go
...ents/image-builder-mk3/pkg/orchestrator/monitor.go
...image-builder-mk3/pkg/orchestrator/orchestrator.go
components/image-builder/pkg/resolve/resolve.go
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
installer/pkg/components/ws-manager/role.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/deployment.go 0.00% <0.00%> (ø)
installer/pkg/common/objects.go 0.00% <0.00%> (ø)
...components/ws-manager/unpriviledged-rolebinding.go 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5837426...7bd3ce7. Read the comment docs.

@mrsimonemms
Copy link
Contributor

/lgtm
/approve

This PR wrongly required @gitpod-io/engineering-workspace approval

@roboquat
Copy link
Contributor

roboquat commented Dec 3, 2021

LGTM label has been added.

Git tree hash: c4c7e48144970ea1ba5e56131f644e7be8cfd23e

@akosyakov
Copy link
Member

/lgtm
/approve no-issue

@corneliusludmann Would you take care about updating docs?

@roboquat
Copy link
Contributor

roboquat commented Dec 6, 2021

LGTM label has been added.

Git tree hash: c4c7e48144970ea1ba5e56131f644e7be8cfd23e

@roboquat
Copy link
Contributor

roboquat commented Dec 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: akosyakov, MrSimonEmms

Associated issue requirement bypassed by: akosyakov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 74d2f69 into main Dec 6, 2021
@roboquat roboquat deleted the clu/phpstorm branch December 6, 2021 07:20
@corneliusludmann
Copy link
Contributor Author

Would you take care about updating docs?

https://github.com/gitpod-io/website/pull/1326

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production labels Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production release-note size/M team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants