Skip to content

Conversation

@csweichel
Copy link
Contributor

Description

This PR fixes dotfile installation in Gitpod workspaces.

Related Issue(s)

Fixes #8281

How to test

  1. Set up a dotfile repo in the preferences
  2. Start a workspace

Release Notes

NONE

Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #8283 (8afd1a8) into main (bfc9ce4) will increase coverage by 19.30%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8283       +/-   ##
===========================================
+ Coverage   12.31%   31.62%   +19.30%     
===========================================
  Files          20       37       +17     
  Lines        1161     5742     +4581     
===========================================
+ Hits          143     1816     +1673     
- Misses       1014     3789     +2775     
- Partials        4      137      +133     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-supervisor-app 35.90% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/supervisor/supervisor.go 6.47% <0.00%> (ø)
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
components/supervisor/pkg/ports/slirp4netns.go 0.00% <0.00%> (ø)
components/supervisor/pkg/supervisor/ssh.go 0.00% <0.00%> (ø)
components/supervisor/pkg/supervisor/user.go 32.29% <0.00%> (ø)
components/supervisor/pkg/supervisor/config.go 4.23% <0.00%> (ø)
components/supervisor/pkg/dropwriter/dropwriter.go 73.46% <0.00%> (ø)
components/supervisor/pkg/config/gitpod-config.go 76.78% <0.00%> (ø)
components/supervisor/pkg/supervisor/git.go 0.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfc9ce4...8afd1a8. Read the comment docs.

@roboquat roboquat merged commit 70e1da2 into main Feb 17, 2022
@roboquat roboquat deleted the cw/fix-8281 branch February 17, 2022 15:05
@iQQBot iQQBot added deployed Change is completely running in production deployed: IDE IDE change is running in production labels Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/XS team: IDE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dotfiles are not being executed or installed

4 participants