Skip to content

test: add E2E tests for database table column resize (#1100)#1104

Merged
sw-factory-automations merged 2 commits into
mainfrom
feat/1100-e2e-column-resize
May 14, 2026
Merged

test: add E2E tests for database table column resize (#1100)#1104
sw-factory-automations merged 2 commits into
mainfrom
feat/1100-e2e-column-resize

Conversation

@sw-factory-automations
Copy link
Copy Markdown
Collaborator

Closes #1100

What

Adds E2E test coverage for the database table column resize feature (drag column border to change width). This was an untested interactive feature that could only be properly verified in a real browser.

How

  • Added data-testid="db-table-resize-handle-{colIndex}" to the resize handle in table-column-header.tsx for reliable test targeting
  • Created e2e/database-column-resize.spec.ts with 4 tests:
    1. Drag to increase width — drags resize handle right, verifies column widens
    2. Drag to decrease width — drags resize handle left, verifies column shrinks
    3. Minimum width constraint — drags far left, verifies width stays ≥ 80px
    4. Other columns unaffected — resizes one column, verifies adjacent column width unchanged
  • Follows the setup/teardown pattern from database-column-reorder.spec.ts
  • Uses Playwright page.mouse.move()/down()/up() for drag simulation with stepped moves

Testing

  • pnpm lint — 0 errors
  • pnpm typecheck — passes
  • pnpm test — 142 files, 1909 tests passed
  • pnpm test:e2e --grep "column resize" — 4/4 passed
  • Updated .agents/quality.md with new test counts (81 E2E specs, 397 tests)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
memo Ready Ready Preview, Comment May 14, 2026 10:48pm

Request Review

@sw-factory-automations sw-factory-automations force-pushed the feat/1100-e2e-column-resize branch from 5d86b76 to e9ec5f2 Compare May 14, 2026 22:06
@sw-factory-automations
Copy link
Copy Markdown
Collaborator Author

[shepherd:conflict] Merge conflicts resolved and rebased on main. Conflicts were in .agents/quality.md (additive — both sides updated test counts). All checks pass (lint, typecheck, 1909 tests).

The WorkspaceHome stories render at 1280x800 after the Import Markdown
action was added (616ee28), but baselines were still 1280x720.
Regenerated all 5 WorkspaceHome snapshots to match current rendering.

Co-authored-by: Ona <no-reply@ona.com>
@sw-factory-automations sw-factory-automations merged commit d6ef63b into main May 14, 2026
9 checks passed
@sw-factory-automations sw-factory-automations deleted the feat/1100-e2e-column-resize branch May 14, 2026 23:03
@sw-factory-automations
Copy link
Copy Markdown
Collaborator Author

✅ Post-merge verification skipped — test: PR does not affect the live app.

@sw-factory-automations
Copy link
Copy Markdown
Collaborator Author

✅ UI verification passed — no visual changes detected.

This PR adds E2E tests and a data-testid attribute to table-column-header.tsx. The only component change (data-testid) has no visual impact. Design spec compliance check not required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: add E2E tests for database table column resize

1 participant