test: add E2E tests for database table column resize (#1100)#1104
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: Ona <no-reply@ona.com>
5d86b76 to
e9ec5f2
Compare
Collaborator
Author
|
[shepherd:conflict] Merge conflicts resolved and rebased on main. Conflicts were in |
The WorkspaceHome stories render at 1280x800 after the Import Markdown action was added (616ee28), but baselines were still 1280x720. Regenerated all 5 WorkspaceHome snapshots to match current rendering. Co-authored-by: Ona <no-reply@ona.com>
Collaborator
Author
|
✅ Post-merge verification skipped — |
Collaborator
Author
|
✅ UI verification passed — no visual changes detected. This PR adds E2E tests and a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1100
What
Adds E2E test coverage for the database table column resize feature (drag column border to change width). This was an untested interactive feature that could only be properly verified in a real browser.
How
data-testid="db-table-resize-handle-{colIndex}"to the resize handle intable-column-header.tsxfor reliable test targetinge2e/database-column-resize.spec.tswith 4 tests:database-column-reorder.spec.tspage.mouse.move()/down()/up()for drag simulation with stepped movesTesting
pnpm lint— 0 errorspnpm typecheck— passespnpm test— 142 files, 1909 tests passedpnpm test:e2e --grep "column resize"— 4/4 passed.agents/quality.mdwith new test counts (81 E2E specs, 397 tests)