test: add E2E tests for database person property type (#1101)#1106
Merged
Conversation
Co-authored-by: Ona <no-reply@ona.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
✅ Post-merge verification skipped — |
Collaborator
Author
|
✅ UI verification skipped — no UI files changed. This PR only adds E2E tests ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1101
What
Adds a dedicated E2E test spec for the database person property type, covering the full interaction flow: opening the member picker, searching, selecting/deselecting members, verifying persistence, and testing the row detail page.
How
New file
e2e/database-person.spec.tswith 5 tests:Setup creates a database with a person property column and one row via the admin client. Cleanup removes all test data.
Testing
pnpm lint— 0 errors (48 pre-existing warnings)pnpm typecheck— cleanpnpm test— 142 files, 1911 tests passedpnpm test:e2e --grep "Person property type"— 5/5 passed (some runs show flaky auth timeouts on first attempt, all pass on retry — this is a pre-existing infrastructure issue affecting all authenticated E2E tests)Notes
During testing, I observed that the
PersonRenderershows empty cells in both the table view and row detail page. The renderer depends on_membersbeing injected intoproperty.configby the server-side prefetch, but this injection appears to fail intermittently (possibly a server-side auth timing issue). ThePersonEditorworks correctly because it fetches members client-side on mount. The tests verify behavior through the editor's checkbox state rather than the renderer's avatar output to avoid coupling to this server-side issue.