fix(editor): move page icon above title for proper alignment#189
Merged
Conversation
The emoji picker was rendered inline with the title, causing misalignment between the title and editor content. Now the icon renders as a block element above the title row. When no icon is set, a small 'Add icon' button appears on hover. Co-authored-by: Ona <no-reply@ona.com>
zacharias-ona
added
the
ona-user
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
Summary: |
4 tasks
Collaborator
Author
|
❌ Post-merge verification failed. E2E results: 46/47 passed, 1 failed
Ad-hoc smoke tests: all passed
See #193. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The emoji picker was rendered inline with the title, pushing it out of alignment with the editor content below.
Changes:
text-4xl) above the title, clickable to change/removeFiles changed:
src/components/page-view-client.tsx— restructured layout soPageIconsits above the title+menu rowsrc/components/page-icon.tsx— two render paths for icon-present vs no-icon states