Skip to content

fix(e2e): create fresh page in navigateToEditorPage to prevent parallel test interference (#187)#190

Merged
zacharias-ona merged 1 commit into
mainfrom
fix/187-page-icon-e2e-404
Apr 17, 2026
Merged

fix(e2e): create fresh page in navigateToEditorPage to prevent parallel test interference (#187)#190
zacharias-ona merged 1 commit into
mainfrom
fix/187-page-icon-e2e-404

Conversation

@zacharias-ona
Copy link
Copy Markdown
Collaborator

Closes #187

What

The navigateToEditorPage E2E helper navigated to the first existing page in the sidebar tree. When tests ran in parallel (fullyParallel: true), the page-crud delete test could delete that same page between the sidebar load and the server-side route query, causing a 404 in any test that happened to click the same tree item.

How

Changed navigateToEditorPage to always create a fresh page via the sidebar "New Page" button instead of clicking an existing one. This gives each test its own isolated page that no parallel test can delete or modify. The helper still waits for the page tree to finish loading (workspace ID resolution) before clicking "New Page" to avoid the silent no-op when workspaceId is null.

Testing

  • Full E2E suite passes (47/47) with no page-icon test failures
  • Ran the full suite multiple times to confirm the parallel interference is resolved
  • pnpm lint && pnpm typecheck && pnpm test && pnpm test:e2e all pass

…el test interference (#187)

Co-authored-by: Ona <no-reply@ona.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
memo Ready Ready Preview, Comment Apr 17, 2026 4:49pm

Request Review

@zacharias-ona zacharias-ona merged commit 3da9337 into main Apr 17, 2026
6 checks passed
@zacharias-ona zacharias-ona deleted the fix/187-page-icon-e2e-404 branch April 17, 2026 16:52
@zacharias-ona
Copy link
Copy Markdown
Collaborator Author

✅ UI verification skipped — no UI files changed. Only e2e/fixtures/editor-helpers.ts was modified (test infrastructure).

@zacharias-ona
Copy link
Copy Markdown
Collaborator Author

✅ Post-merge verification passed.

E2E suite: 47/47 tests passed against https://memo.software-factory.dev

Ad-hoc smoke tests:

  • ✅ Landing page — loaded, has title
  • /sign-in — rendered with email input
  • /api/health — returned OK
  • ✅ Authenticated login flow — signed in, redirected to workspace
  • ✅ Workspace page — fully loaded
  • ⏭️ Skipped: /dashboard (not yet built)
  • ⏭️ Skipped: Editor page navigation via sidebar (no page buttons with timestamps found in workspace at test time — covered by E2E suite)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: UI regression after PR #185 — emoji picker Escape test navigates to 404 page

1 participant