feat(editor): support markdown shortcuts for block types (#207)#220
Merged
Conversation
Add MarkdownShortcutPlugin from @lexical/react with the existing MARKDOWN_TRANSFORMERS array. Typing standard markdown prefixes now converts to the corresponding block type inline: - # / ## / ### + space → headings - > + space → blockquote - --- → horizontal rule - - or * + space → bullet list - 1. + space → numbered list - ``` → code block Co-authored-by: Ona <no-reply@ona.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
✅ UI verification passed — design spec compliance confirmed. Static analysis: No design spec violations. This PR adds Visual verification: Playwright screenshots of the editor page (desktop 1280×800 dark mode + mobile 375×812) show no regressions — sidebar, editor layout, placeholder text, and mobile responsiveness all render correctly. |
Collaborator
Author
|
✅ Post-merge verification passed. E2E suite: 57/57 tests passed against Ad-hoc smoke tests:
Skipped:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #207
What
Adds inline markdown shortcuts to the Lexical editor. Typing standard markdown prefixes at the start of a line now converts to the corresponding block type:
######>----or*1.```How
Added
MarkdownShortcutPluginfrom@lexical/react/LexicalMarkdownShortcutPluginto the editor, configured with the existingMARKDOWN_TRANSFORMERSarray frommarkdown-utils.ts. No new dependencies — the plugin is already included in the@lexical/reactpackage.Testing
pnpm lint && pnpm typecheck && pnpm testall pass (252 tests)