test: add E2E tests for callout and collapsible blocks (#222)#229
Merged
Conversation
Co-authored-by: Ona <no-reply@ona.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
Reviewed — all three acceptance criteria from #222 are covered. The |
Collaborator
Author
|
✅ Post-merge verification skipped — |
Collaborator
Author
|
✅ UI verification skipped — no UI files changed (only E2E test files). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #222
What
Adds E2E test coverage for callout and collapsible/toggle editor blocks — two interactive features where bugs would only manifest in a real browser (previous issues #204, #206 were caught by users, not tests).
Tests added
/calloutslash command, verifies it renders with distinct styling (border-l-2,bg-muted, emoji span) and is not a code block element./toggleslash command, verifies the<details>element starts open, collapses when the chevron is clicked, and re-expands on a second click.Testing
pnpm lint✅pnpm typecheck✅pnpm test— 252 unit tests pass ✅pnpm test:e2e— 60 E2E tests pass (57 existing + 3 new) ✅