Skip to content

test: add E2E tests for callout and collapsible blocks (#222)#229

Merged
zacharias-ona merged 1 commit into
mainfrom
feat/222-e2e-callout-collapsible
Apr 18, 2026
Merged

test: add E2E tests for callout and collapsible blocks (#222)#229
zacharias-ona merged 1 commit into
mainfrom
feat/222-e2e-callout-collapsible

Conversation

@zacharias-ona
Copy link
Copy Markdown
Collaborator

Closes #222

What

Adds E2E test coverage for callout and collapsible/toggle editor blocks — two interactive features where bugs would only manifest in a real browser (previous issues #204, #206 were caught by users, not tests).

Tests added

  1. Callout block — inserts via /callout slash command, verifies it renders with distinct styling (border-l-2, bg-muted, emoji span) and is not a code block element.
  2. Toggle expand/collapse — inserts via /toggle slash command, verifies the <details> element starts open, collapses when the chevron is clicked, and re-expands on a second click.
  3. Toggle content persistence — types custom text inside the collapsible content area, then collapses and re-expands to verify the content persists across toggle cycles.

Testing

  • pnpm lint
  • pnpm typecheck
  • pnpm test — 252 unit tests pass ✅
  • pnpm test:e2e — 60 E2E tests pass (57 existing + 3 new) ✅

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
memo Ready Ready Preview, Comment Apr 18, 2026 7:39am

Request Review

@zacharias-ona
Copy link
Copy Markdown
Collaborator Author

Reviewed — all three acceptance criteria from #222 are covered. The insertViaSlashCommand helper follows the established pattern from editor-slash-commands.spec.ts. Assertions check DOM structure, attributes, visibility, and text content. No issues found. Merging.

@zacharias-ona zacharias-ona merged commit 3efeff1 into main Apr 18, 2026
6 checks passed
@zacharias-ona zacharias-ona deleted the feat/222-e2e-callout-collapsible branch April 18, 2026 07:42
@zacharias-ona
Copy link
Copy Markdown
Collaborator Author

✅ Post-merge verification skipped — test: PR does not affect the live app.

@zacharias-ona
Copy link
Copy Markdown
Collaborator Author

✅ UI verification skipped — no UI files changed (only E2E test files).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: add E2E tests for callout and collapsible blocks

1 participant